mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 21:15:56 +03:00
[GH-ISSUE #790] Migrate from erusev/parsedown to league/commonmark #478
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#478
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marclaporte on GitHub (Oct 10, 2023).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/790
Now: https://packagist.org/packages/erusev/parsedown
I want us to move to https://packagist.org/packages/league/commonmark
Why?
Tiki developers (who contribute a lot to Cypht) are experienced with league/commonmark: https://doc.tiki.org/Tiki-Flavored-Markdown
So in general, it makes sense to harmonize for the dependencies.
Both packages are popular and maintained. However, league/commonmark has more sub-depedencies. Not an issue for Tiki, but Cypht tries to be more lightweight.
@kroky commented on GitHub (Oct 11, 2023):
It would add just a couple more composer packages to the vendor dir. Doesn't seem a big change. Also, Cypht currently uses Parsedown in just one place, so replacing will be easy.
@kambereBr commented on GitHub (Oct 29, 2023):
Here is the Pull Request : https://github.com/cypht-org/cypht/pull/812
@marclaporte commented on GitHub (Oct 29, 2023):
league/commonmark is much more active:
https://openhub.net/p/_compare?project_0=league%2Fcommonmark+%28PHP%29&project_1=parsedown