[PR #358] [MERGED] show alert when trying to sign message without existing profile #790

New issue

Closed

opened 2026-02-25 21:36:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/358
Author: @yvesdaxmaz
Created: 10/23/2019
Status: ✅ Merged
Merged: 11/17/2019
Merged by: @jasonmunro

Base: master ← Head: signing_alert

📝 Commits (1)

61b2d75 show alert when trying to sign message without existing profile

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 modules/profiles/site.js (+2 -0)

📄 Description

Pullrequest

When composing a message under the message textarea there are "Sign" button which as purpose to add signature to a message but, the button isn't self explanatore. So to add some explanation when the button is clicked instead of showing nothing to showcase some interaction of the button. I add an alert which tell the user what to do before that feature to be avalable.

Issues

None

Checklist

None

How2Test

compose a new message without defining any profile in cypht. And under the message textarea click on the sign button.

Todo

None

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/358 **Author:** [@yvesdaxmaz](https://github.com/yvesdaxmaz) **Created:** 10/23/2019 **Status:** ✅ Merged **Merged:** 11/17/2019 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `signing_alert` --- ### 📝 Commits (1) - [`61b2d75`](https://github.com/cypht-org/cypht/commit/61b2d75f1f067b2c6430bb45df4a64f34789b07e) show alert when trying to sign message without existing profile ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/profiles/site.js` (+2 -0) </details> ### 📄 Description ## Pullrequest  When composing a message under the message textarea there are "Sign" button which as purpose to add signature to a message but, the button isn't self explanatore. So to add some explanation when the button is clicked instead of showing nothing to showcase some interaction of the button. I add an alert which tell the user what to do before that feature to be avalable. ### Issues  - [X] None ### Checklist  - [X] None ### How2Test   - [X] compose a new message without defining any profile in cypht. And under the message textarea click on the sign button. ### Todo  - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>