[PR #1467] [CLOSED] fix(backend): fix error when adding new mail server #1536

New issue

Closed

opened 2026-02-25 21:38:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1467
Author: @indridieinarsson
Created: 3/10/2025
Status: ❌ Closed

Base: master ← Head: pr_fix_error_add_smtp

📝 Commits (2)

0cc0c22 Prevent clash when adding smtp server
308b158 explicitly wait for sys_messages to appear

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 modules/core/handler_modules.php (+3 -1)
📝 tests/selenium/settings.py (+1 -0)

📄 Description

🍰 Pullrequest

When adding a new mailserver, sometimes there is an error when adding the smtp server (adding only imap server sidesteps the error message). This is probably a regression from pr #1425.

To Review

Review that adding smtp server still works for ews or jmap servers - the code from #1425 that added a call to connect_to_smtp_server addressed an issue with those kinds of servers. The change in this PR shouldn't affect that code, but I can't really test it reliably.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1467 **Author:** [@indridieinarsson](https://github.com/indridieinarsson) **Created:** 3/10/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `pr_fix_error_add_smtp` --- ### 📝 Commits (2) - [`0cc0c22`](https://github.com/cypht-org/cypht/commit/0cc0c22667f3c54a55da818281f5aed00f39c60f) Prevent clash when adding smtp server - [`308b158`](https://github.com/cypht-org/cypht/commit/308b158f0b34691c04b53308ae49196678852742) explicitly wait for sys_messages to appear ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/handler_modules.php` (+3 -1) 📝 `tests/selenium/settings.py` (+1 -0) </details> ### 📄 Description ## 🍰 Pullrequest When adding a new mailserver, sometimes there is an error when adding the smtp server (adding only imap server sidesteps the error message). This is probably a regression from pr #1425. ### To Review - Review that adding smtp server still works for ews or jmap servers - the code from #1425 that added a call to `connect_to_smtp_server` addressed an issue with those kinds of servers. The change in this PR shouldn't affect that code, but I can't really test it reliably. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>