[PR #1378] [MERGED] Review and fix the implementation of the tags feature #1467

New issue

Closed

opened 2026-02-25 21:38:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:38:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1378
Author: @mercihabam
Created: 11/21/2024
Status: ✅ Merged
Merged: 11/23/2024
Merged by: @mercihabam

Base: master ← Head: fix-tags

📝 Commits (7)

4dbd93c WIP: Review and fix the tags feature
3e1cd98 More fixes: the tags ids do change on each reload, the folder is registered when adding a tag, & msgs are llisted
1e14725 Alter the tags storage structure to also save the msg uids as part of the tag rather than altering the message entry in the imap server
2a9a10c Move output modules to their appropriate file
046a016 Fix the tag handler called mutiple times
0617240 Revert changes made to merge_imap_search_results(). It is not needed anymore
9aaee7b Does this hinder the selenium tests?

📊 Changes

12 files changed (+524 additions, -490 deletions)

View changed files

📝 lib/repository.php (+4 -1)
📝 modules/core/navigation/utils.js (+2 -0)
📝 modules/imap/functions.php (+0 -38)
📝 modules/imap/handler_modules.php (+0 -38)
📝 modules/imap/js_modules/route_handlers.js (+1 -2)
📝 modules/imap/setup.php (+0 -8)
📝 modules/imap/site.js (+3 -11)
➕ modules/tags/handler_modules.php (+192 -0)
📝 modules/tags/hm-tags.php (+41 -0)
📝 modules/tags/modules.php (+4 -392)
➕ modules/tags/output_modules.php (+267 -0)
📝 modules/tags/setup.php (+10 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1378 **Author:** [@mercihabam](https://github.com/mercihabam) **Created:** 11/21/2024 **Status:** ✅ Merged **Merged:** 11/23/2024 **Merged by:** [@mercihabam](https://github.com/mercihabam) **Base:** `master` ← **Head:** `fix-tags` --- ### 📝 Commits (7) - [`4dbd93c`](https://github.com/cypht-org/cypht/commit/4dbd93cc8a1db067aeb7dcff637fe9661b8cd034) WIP: Review and fix the tags feature - [`3e1cd98`](https://github.com/cypht-org/cypht/commit/3e1cd982b2fdbded29c1c02415b4d1e6bffaab80) More fixes: the tags ids do change on each reload, the folder is registered when adding a tag, & msgs are llisted - [`1e14725`](https://github.com/cypht-org/cypht/commit/1e14725b46f9af337793571b0ede35e48b7afe7f) Alter the tags storage structure to also save the msg uids as part of the tag rather than altering the message entry in the imap server - [`2a9a10c`](https://github.com/cypht-org/cypht/commit/2a9a10ccdc5a14c69253a09ee48de04b62d59390) Move output modules to their appropriate file - [`046a016`](https://github.com/cypht-org/cypht/commit/046a01663a57866a766d185af18dad04511e7f9a) Fix the tag handler called mutiple times - [`0617240`](https://github.com/cypht-org/cypht/commit/0617240128d462635e8103f6a3400eabfa99ff65) Revert changes made to merge_imap_search_results(). It is not needed anymore - [`9aaee7b`](https://github.com/cypht-org/cypht/commit/9aaee7bd9e0b01cad794a515be3e5c93f9962635) Does this hinder the selenium tests? ### 📊 Changes **12 files changed** (+524 additions, -490 deletions) <details> <summary>View changed files</summary> 📝 `lib/repository.php` (+4 -1) 📝 `modules/core/navigation/utils.js` (+2 -0) 📝 `modules/imap/functions.php` (+0 -38) 📝 `modules/imap/handler_modules.php` (+0 -38) 📝 `modules/imap/js_modules/route_handlers.js` (+1 -2) 📝 `modules/imap/setup.php` (+0 -8) 📝 `modules/imap/site.js` (+3 -11) ➕ `modules/tags/handler_modules.php` (+192 -0) 📝 `modules/tags/hm-tags.php` (+41 -0) 📝 `modules/tags/modules.php` (+4 -392) ➕ `modules/tags/output_modules.php` (+267 -0) 📝 `modules/tags/setup.php` (+10 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>