[PR #1199] [MERGED] Correct sieve connection when using scheme #1333

New issue

Closed

opened 2026-02-25 21:37:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1199
Author: @Shadow243
Created: 8/27/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @josaphatim

Base: master ← Head: correct-sieve-error-with-scheme

📝 Commits (4)

18c2c4a Correct sieve connection when using scheme
6ca536a Make sieve tls mode dynamic to support all servers
d522c61 Enable sieve check on login with auth_type DB
5602987 Sieve tls option in bulk import

📊 Changes

16 files changed (+76 additions, -31 deletions)

View changed files

📝 .env.example (+1 -0)
📝 config/app.php (+10 -2)
📝 lib/auth.php (+5 -2)
📝 modules/core/handler_modules.php (+5 -2)
📝 modules/core/setup.php (+1 -0)
📝 modules/core/site.js (+10 -1)
📝 modules/imap/functions.php (+6 -7)
📝 modules/imap/handler_modules.php (+1 -0)
📝 modules/imap/output_modules.php (+14 -4)
📝 modules/nux/assets/data/server_accounts_sample.csv (+3 -3)
📝 modules/nux/assets/data/server_accounts_sample.yaml (+4 -2)
📝 modules/nux/modules.php (+2 -0)
📝 modules/nux/services.php (+6 -3)
📝 modules/sievefilters/hm-sieve.php (+2 -2)
📝 modules/smtp/hm-smtp.php (+0 -1)
📝 scripts/create_config.php (+6 -2)

📄 Description

I added a checkbox that will be used to enable or disable TLS, instead of relying on the Sieve host starting with 'tls://'. With Migadu, even when TLS mode is set to true, we use the host without 'tls://'. However, with Stalwart, 'tls://' is required. In the older version, we were removing it before sending the request to the server at https://github.com/cypht-org/cypht/pull/1199/files#diff-f546b2284fe2ff1bd3c96ced190bc15d442480a4ebe1da5c82a2a59dd1b97505R1511 in parse_url function.

Related issue: https://github.com/cypht-org/cypht/issues/1153

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1199 **Author:** [@Shadow243](https://github.com/Shadow243) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@josaphatim](https://github.com/josaphatim) **Base:** `master` ← **Head:** `correct-sieve-error-with-scheme` --- ### 📝 Commits (4) - [`18c2c4a`](https://github.com/cypht-org/cypht/commit/18c2c4a79eab244a47d032efc28dea8ecc1dad33) Correct sieve connection when using scheme - [`6ca536a`](https://github.com/cypht-org/cypht/commit/6ca536a65ca67435610dbad305991a3569c76929) Make sieve tls mode dynamic to support all servers - [`d522c61`](https://github.com/cypht-org/cypht/commit/d522c61eb3abf9a170e4c201f91091c5b55f36f7) Enable sieve check on login with auth_type DB - [`5602987`](https://github.com/cypht-org/cypht/commit/560298722601ec031c9a823c03c3cf85ce8f06ff) Sieve tls option in bulk import ### 📊 Changes **16 files changed** (+76 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -0) 📝 `config/app.php` (+10 -2) 📝 `lib/auth.php` (+5 -2) 📝 `modules/core/handler_modules.php` (+5 -2) 📝 `modules/core/setup.php` (+1 -0) 📝 `modules/core/site.js` (+10 -1) 📝 `modules/imap/functions.php` (+6 -7) 📝 `modules/imap/handler_modules.php` (+1 -0) 📝 `modules/imap/output_modules.php` (+14 -4) 📝 `modules/nux/assets/data/server_accounts_sample.csv` (+3 -3) 📝 `modules/nux/assets/data/server_accounts_sample.yaml` (+4 -2) 📝 `modules/nux/modules.php` (+2 -0) 📝 `modules/nux/services.php` (+6 -3) 📝 `modules/sievefilters/hm-sieve.php` (+2 -2) 📝 `modules/smtp/hm-smtp.php` (+0 -1) 📝 `scripts/create_config.php` (+6 -2) </details> ### 📄 Description I added a checkbox that will be used to enable or disable TLS, instead of relying on the Sieve host starting with 'tls://'. With Migadu, even when TLS mode is set to true, we use the host without 'tls://'. However, with Stalwart, 'tls://' is required. In the older version, we were removing it before sending the request to the server at https://github.com/cypht-org/cypht/pull/1199/files#diff-f546b2284fe2ff1bd3c96ced190bc15d442480a4ebe1da5c82a2a59dd1b97505R1511 in `parse_url` function. - Related issue: [https://github.com/cypht-org/cypht/issues/1153](https://github.com/cypht-org/cypht/issues/1153) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>