[PR #995] [MERGED] Fixed add filter issues #1199

New issue

Closed

opened 2026-02-25 21:37:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/995
Author: @josaphatim
Created: 5/2/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @kroky

Base: master ← Head: fixed-issue-with-sieve-add-filter

📝 Commits (1)

f6489e9 Fixed add filter issues

📊 Changes

5 files changed (+12 additions, -10 deletions)

View changed files

📝 modules/core/output_modules.php (+1 -1)
📝 modules/core/site.css (+3 -3)
📝 modules/core/site.js (+0 -1)
📝 modules/sievefilters/site.js (+7 -4)
📝 tests/phpunit/modules/core/modules.php (+1 -1)

📄 Description

This PR fixes some issue with add filter/add script buttons.
First the save button was calling unexisting close function
Also it raise the z-index of alerts so they won't be hidden by modal
Also when editing a filter, it fixes the default value of action when it is a textarea. The value was not set.
Finally it fixes the conditions/actions which were not cleared after clicking on one. To reproduce this click on edit icon of a filter then close the modal, click edit on another filter you will see that they will be combined.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/995 **Author:** [@josaphatim](https://github.com/josaphatim) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `fixed-issue-with-sieve-add-filter` --- ### 📝 Commits (1) - [`f6489e9`](https://github.com/cypht-org/cypht/commit/f6489e92754f101c012e60d461458b7e5065a570) Fixed add filter issues ### 📊 Changes **5 files changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/output_modules.php` (+1 -1) 📝 `modules/core/site.css` (+3 -3) 📝 `modules/core/site.js` (+0 -1) 📝 `modules/sievefilters/site.js` (+7 -4) 📝 `tests/phpunit/modules/core/modules.php` (+1 -1) </details> ### 📄 Description This PR fixes some issue with add filter/add script buttons. First the save button was calling unexisting close function Also it raise the z-index of alerts so they won't be hidden by modal Also when editing a filter, it fixes the default value of action when it is a textarea. The value was not set. Finally it fixes the conditions/actions which were not cleared after clicking on one. To reproduce this click on edit icon of a filter then close the modal, click edit on another filter you will see that they will be combined. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>