[PR #1021] [MERGED] [FIX]Error Ocurred when attempting gmail oauth2 setup #1213

New issue

Closed

opened 2026-02-25 21:37:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/1021
Author: @christer77
Created: 5/14/2024
Status: ✅ Merged
Merged: 5/15/2024
Merged by: @kroky

Base: master ← Head: Error-Ocurred-when-attempting-gmail-oauth2-setup

📝 Commits (1)

92f66b7 [ENH]Error Ocurred when attempting gmail oauth2 setup

📊 Changes

4 files changed (+8 additions, -8 deletions)

View changed files

📝 lib/framework.php (+2 -2)
📝 lib/ini_set.php (+1 -1)
📝 lib/session_base.php (+3 -3)
📝 modules/api_login/modules.php (+2 -2)

📄 Description

For issue !776 and this !978
We found that the SameSite option for the cookie caused a redirect to cypht after a successful authentication from OAuth2 failed. As a solution, we used Lax instead of Strict value for hm_session and hm_id cookies, which worked perfectly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/1021 **Author:** [@christer77](https://github.com/christer77) **Created:** 5/14/2024 **Status:** ✅ Merged **Merged:** 5/15/2024 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `Error-Ocurred-when-attempting-gmail-oauth2-setup` --- ### 📝 Commits (1) - [`92f66b7`](https://github.com/cypht-org/cypht/commit/92f66b7a9ba49961e1e13a6ab04a2d628259754e) [ENH]Error Ocurred when attempting gmail oauth2 setup ### 📊 Changes **4 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `lib/framework.php` (+2 -2) 📝 `lib/ini_set.php` (+1 -1) 📝 `lib/session_base.php` (+3 -3) 📝 `modules/api_login/modules.php` (+2 -2) </details> ### 📄 Description For [issue !776 ](https://github.com/cypht-org/cypht/issues/776) and [this !978](https://github.com/cypht-org/cypht/issues/978) We found that the SameSite option for the cookie caused a redirect to cypht after a successful authentication from OAuth2 failed. As a solution, we used Lax instead of Strict value for hm_session and hm_id cookies, which worked perfectly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>