[PR #744] [CLOSED] Fix: broken icon image when trying to switch to a theme that alters icon colors #1021

Closed
opened 2026-02-25 21:36:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/744
Author: @Yannick243
Created: 8/12/2023
Status: Closed

Base: 1.4.xHead: broken-icon-image


📝 Commits (10+)

  • f4c0fd9 Added possibility to see and edit behavior per email/domain blocked
  • d47664e Ref: simplifier download options
  • 004cf96 Ref: Simplifier download option
  • ce28f85 Fixed bugs on dropdown and refactored js
  • a9a5779 Merge pull request #731 from josaphatim/edit-account-behavior
  • 3ad8c5b Fix: update gitignore
  • 2f2b3fc Ref: Set simple UI as default
  • 6b988a7 Fixed disposition attachment when it is not an array
  • 92642e6 Merge pull request #736 from josaphatim/fix-struct-array-issue
  • 23cd9cd Handled unsupported charsets on mb_convert_encoding

📊 Changes

13 files changed (+250 additions, -73 deletions)

View changed files

📝 composer.json (+1 -0)
📝 modules/core/message_functions.php (+12 -2)
📝 modules/imap/functions.php (+44 -14)
📝 modules/imap/handler_modules.php (+2 -2)
📝 modules/imap/output_modules.php (+3 -15)
📝 modules/imap/setup.php (+2 -0)
📝 modules/imap/site.css (+0 -4)
📝 modules/imap/site.js (+0 -7)
📝 modules/sievefilters/modules.php (+90 -22)
📝 modules/sievefilters/setup.php (+3 -3)
📝 modules/sievefilters/site.css (+25 -0)
📝 modules/sievefilters/site.js (+67 -3)
📝 modules/themes/modules.php (+1 -1)

📄 Description

This PR fixes the icon image by adding a space before the fill attribute on the svg icon image as described in the related issue below.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/744 **Author:** [@Yannick243](https://github.com/Yannick243) **Created:** 8/12/2023 **Status:** ❌ Closed **Base:** `1.4.x` ← **Head:** `broken-icon-image` --- ### 📝 Commits (10+) - [`f4c0fd9`](https://github.com/cypht-org/cypht/commit/f4c0fd9eafe9f62b2e0941de5ef279ff7555b397) Added possibility to see and edit behavior per email/domain blocked - [`d47664e`](https://github.com/cypht-org/cypht/commit/d47664e1a3eae66d0375764c4e6ffebf656414e9) Ref: simplifier download options - [`004cf96`](https://github.com/cypht-org/cypht/commit/004cf969338f67d7f4dd979d7943f2d073087f13) Ref: Simplifier download option - [`ce28f85`](https://github.com/cypht-org/cypht/commit/ce28f85be13fefb82ce42c462b8f40862780c95d) Fixed bugs on dropdown and refactored js - [`a9a5779`](https://github.com/cypht-org/cypht/commit/a9a5779e162d671a21a5eee6ad8fac83e59db229) Merge pull request #731 from josaphatim/edit-account-behavior - [`3ad8c5b`](https://github.com/cypht-org/cypht/commit/3ad8c5b887041c9779a940ff1b6224447266f59f) Fix: update gitignore - [`2f2b3fc`](https://github.com/cypht-org/cypht/commit/2f2b3fcbbcba04cc771d0df1614478d60fc1ad2c) Ref: Set simple UI as default - [`6b988a7`](https://github.com/cypht-org/cypht/commit/6b988a778a305c29a3e05af458a940acfd63e0e6) Fixed disposition attachment when it is not an array - [`92642e6`](https://github.com/cypht-org/cypht/commit/92642e670c04cf93d76ae377f08026813dee2da4) Merge pull request #736 from josaphatim/fix-struct-array-issue - [`23cd9cd`](https://github.com/cypht-org/cypht/commit/23cd9cd49eb559420a43b32a80dfcfeee6ea5382) Handled unsupported charsets on mb_convert_encoding ### 📊 Changes **13 files changed** (+250 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -0) 📝 `modules/core/message_functions.php` (+12 -2) 📝 `modules/imap/functions.php` (+44 -14) 📝 `modules/imap/handler_modules.php` (+2 -2) 📝 `modules/imap/output_modules.php` (+3 -15) 📝 `modules/imap/setup.php` (+2 -0) 📝 `modules/imap/site.css` (+0 -4) 📝 `modules/imap/site.js` (+0 -7) 📝 `modules/sievefilters/modules.php` (+90 -22) 📝 `modules/sievefilters/setup.php` (+3 -3) 📝 `modules/sievefilters/site.css` (+25 -0) 📝 `modules/sievefilters/site.js` (+67 -3) 📝 `modules/themes/modules.php` (+1 -1) </details> ### 📄 Description This PR fixes the icon image by adding a space before the ***fill*** attribute on the svg icon image as described in the related issue below. ### Related issues - [https://github.com/cypht-org/cypht/issues/741)](https://github.com/cypht-org/cypht/issues/741) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#1021
No description provided.