[PR #113] [MERGED] Implement async event pattern for PhaseEvent (v1.20.0) #113

New issue

Closed

opened 2026-02-26 17:44:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:44:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-autosnap/pull/113
Author: @franklupo
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @franklupo

Base: master ← Head: feature/async-phase-event

📝 Commits (1)

e5d8e2c Implement async event pattern for PhaseEvent and bump version to 1.20.0

📊 Changes

3 files changed (+30 additions, -32 deletions)

View changed files

📝 Directory.Build.props (+1 -1)
📝 src/Corsinvest.ProxmoxVE.AutoSnap.Api/Application.cs (+25 -29)
📝 src/Corsinvest.ProxmoxVE.AutoSnap/Commands.cs (+4 -2)

📄 Description

Summary

Replace EventHandler<PhaseEventArgs> with Func<PhaseEventArgs, Task> to support async handlers
CallPhaseEventAsync iterates GetInvocationList() to await each subscriber individually
Update Commands.App_PhaseEvent signature to match new delegate type
Bump version 1.19.0 → 1.20.0

Test plan

Run snap command and verify phase events fire correctly
Run clean command and verify phase events fire correctly
Verify script hook execution still works as expected

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-autosnap/pull/113 **Author:** [@franklupo](https://github.com/franklupo) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `feature/async-phase-event` --- ### 📝 Commits (1) - [`e5d8e2c`](https://github.com/Corsinvest/cv4pve-autosnap/commit/e5d8e2cc366f91aa26f456cc00c7c562d74371de) Implement async event pattern for PhaseEvent and bump version to 1.20.0 ### 📊 Changes **3 files changed** (+30 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Build.props` (+1 -1) 📝 `src/Corsinvest.ProxmoxVE.AutoSnap.Api/Application.cs` (+25 -29) 📝 `src/Corsinvest.ProxmoxVE.AutoSnap/Commands.cs` (+4 -2) </details> ### 📄 Description ## Summary - Replace `EventHandler<PhaseEventArgs>` with `Func<PhaseEventArgs, Task>` to support async handlers - `CallPhaseEventAsync` iterates `GetInvocationList()` to await each subscriber individually - Update `Commands.App_PhaseEvent` signature to match new delegate type - Bump version `1.19.0` → `1.20.0` ## Test plan - [ ] Run `snap` command and verify phase events fire correctly - [ ] Run `clean` command and verify phase events fire correctly - [ ] Verify script hook execution still works as expected --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>