[GH-ISSUE #6] Bug: Comment detection on host line is missing #6

Closed
opened 2026-03-02 05:09:05 +03:00 by kerem · 3 comments
Owner

Originally created by @Mte90 on GitHub (May 15, 2020).
Original GitHub issue: https://github.com/goodhosts/cli/issues/6

Originally assigned to: @luthermonson on GitHub.

If a line include a comment and we are adding to the same ip new domain they are added after the comment example:

192.168.50.4 vvv # VAGRANT: db53e7b49dc0f3aa85fa47b3d00a40e6 (default) / e605922e-40d0-4629-9db0-8bf0ce7d3670 vvv.test auto.test tideways.vvv.test xhgui.vvv.test

If I do

cli r vvv

The line is:

192.168.50.4 # VAGRANT: db53e7b49dc0f3aa85fa47b3d00a40e6 (default) / e605922e-40d0-4629-9db0-8bf0ce7d3670 vvv.test auto.test tideways.vvv.test xhgui.vvv.test

So basically if we are adding or deleting something this changes will happens anyway with the comment but new stuff will be appended after the comment.

Originally created by @Mte90 on GitHub (May 15, 2020). Original GitHub issue: https://github.com/goodhosts/cli/issues/6 Originally assigned to: @luthermonson on GitHub. If a line include a comment and we are adding to the same ip new domain they are added after the comment example: ``` 192.168.50.4 vvv # VAGRANT: db53e7b49dc0f3aa85fa47b3d00a40e6 (default) / e605922e-40d0-4629-9db0-8bf0ce7d3670 vvv.test auto.test tideways.vvv.test xhgui.vvv.test ``` If I do ``` cli r vvv ``` The line is: ``` 192.168.50.4 # VAGRANT: db53e7b49dc0f3aa85fa47b3d00a40e6 (default) / e605922e-40d0-4629-9db0-8bf0ce7d3670 vvv.test auto.test tideways.vvv.test xhgui.vvv.test ``` So basically if we are adding or deleting something this changes will happens anyway with the comment but new stuff will be appended after the comment.
kerem 2026-03-02 05:09:05 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@luthermonson commented on GitHub (May 21, 2020):

super good catch, ill try and fix this weekend.

<!-- gh-comment-id:631945265 --> @luthermonson commented on GitHub (May 21, 2020): super good catch, ill try and fix this weekend.
Author
Owner

@luthermonson commented on GitHub (May 26, 2020):

@Mte90 think this is fixed, give v1.0.2 a try, close the issue if you’re good.

<!-- gh-comment-id:633752936 --> @luthermonson commented on GitHub (May 26, 2020): @Mte90 think this is fixed, give v1.0.2 a try, close the issue if you’re good.
Author
Owner

@Mte90 commented on GitHub (May 26, 2020):

confirmed, this fixed the issue

<!-- gh-comment-id:633917869 --> @Mte90 commented on GitHub (May 26, 2020): confirmed, this fixed the issue
Sign in to join this conversation.
No labels
bug
bug
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cli#6
No description provided.