starred/cli-continues

Fork 0

mirror of https://github.com/yigitkonur/cli-continues.git synced 2026-04-26 00:36:02 +03:00

[PR #26] [MERGED] fix windows cross-tool handoff breaking on cmd.exe #26

New issue

Closed

opened 2026-03-04 01:39:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:39:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yigitkonur/cli-continues/pull/26
Author: @yigitkonur
Created: 3/2/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @yigitkonur

Base: main ← Head: fix/windows-cross-tool-handoff

📝 Commits (2)

804354d fix: use cmd.exe-safe prompt for cross-tool handoff on windows
07d9bf7 address pr review: use TOOL_NAMES in tests, type-safe stubs, mandatory handoff write on windows

📊 Changes

2 files changed (+90 additions, -2 deletions)

View changed files

➕ src/__tests__/windows-safe-prompt.test.ts (+60 -0)
📝 src/utils/resume.ts (+30 -2)

📄 Description

fixes cross-tool resume on windows — cmd.exe splits the multi-line prompt at newlines, so codex/claude/etc see broken args. now uses a short single-line prompt pointing to the handoff file instead.

fixes #17

cc @NeverBeLazyG @GhalebAldoboni @ThunderCls — would appreciate if you could test this when it lands

Review all of them with eye of John Carmack-like simplicity with elegeance approach and apply the one only if required

Greptile Summary

Fixes cross-tool handoff on Windows by bypassing cmd.exe's multi-line prompt issues. Uses a short single-line prompt referencing .continues-handoff.md instead of embedding full context. Solid fix with one test issue:

Core logic is sound — detects Windows and short-circuits to safe prompt
Preserves file-based handoff mechanism (already working)
Test coverage validates single-line, no metacharacters, length constraints
Issue: Test hardcodes 7 tools instead of importing TOOL_NAMES (misses 9 tools, violates registry-single-source-of-truth rule)

Confidence Score: 4/5

Safe to merge after fixing test's hardcoded tool list
Core fix is correct and well-tested. The hardcoded tool list in tests doesn't affect runtime behavior but should be fixed to maintain test coverage for all 16 supported tools
Fix the hardcoded tool list in src/__tests__/windows-safe-prompt.test.ts:51 before merging

Important Files Changed

Filename	Overview
src/tests/windows-safe-prompt.test.ts	New test suite for Windows-safe prompt generation with good coverage, but hardcodes tool list instead of deriving from TOOL_NAMES
src/utils/resume.ts	Clean Windows fix that bypasses multi-line prompts on cmd.exe by using single-line file reference

_{Last reviewed commit: 804354d}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yigitkonur/cli-continues/pull/26 **Author:** [@yigitkonur](https://github.com/yigitkonur) **Created:** 3/2/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@yigitkonur](https://github.com/yigitkonur) **Base:** `main` ← **Head:** `fix/windows-cross-tool-handoff` --- ### 📝 Commits (2) - [`804354d`](https://github.com/yigitkonur/cli-continues/commit/804354dcdb0fa95e66542c955280321b0667fa37) fix: use cmd.exe-safe prompt for cross-tool handoff on windows - [`07d9bf7`](https://github.com/yigitkonur/cli-continues/commit/07d9bf7096e9250b60b5d15096040bc4d166c6fb) address pr review: use TOOL_NAMES in tests, type-safe stubs, mandatory handoff write on windows ### 📊 Changes **2 files changed** (+90 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `src/__tests__/windows-safe-prompt.test.ts` (+60 -0) 📝 `src/utils/resume.ts` (+30 -2) </details> ### 📄 Description fixes cross-tool resume on windows — cmd.exe splits the multi-line prompt at newlines, so codex/claude/etc see broken args. now uses a short single-line prompt pointing to the handoff file instead. fixes #17 cc @NeverBeLazyG @GhalebAldoboni @ThunderCls — would appreciate if you could test this when it lands  --- <a href="https://app.devin.ai/review/yigitkonur/cli-continues/pull/26" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>   # Review all of them with eye of John Carmack-like simplicity with elegeance approach and apply the one only if required <h3>Greptile Summary</h3> Fixes cross-tool handoff on Windows by bypassing cmd.exe's multi-line prompt issues. Uses a short single-line prompt referencing `.continues-handoff.md` instead of embedding full context. Solid fix with one test issue: - Core logic is sound — detects Windows and short-circuits to safe prompt - Preserves file-based handoff mechanism (already working) - Test coverage validates single-line, no metacharacters, length constraints - **Issue**: Test hardcodes 7 tools instead of importing `TOOL_NAMES` (misses 9 tools, violates registry-single-source-of-truth rule) <details><summary><h3>Confidence Score: 4/5</h3></summary> - Safe to merge after fixing test's hardcoded tool list - Core fix is correct and well-tested. The hardcoded tool list in tests doesn't affect runtime behavior but should be fixed to maintain test coverage for all 16 supported tools - Fix the hardcoded tool list in `src/__tests__/windows-safe-prompt.test.ts:51` before merging </details> <details open><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | src/__tests__/windows-safe-prompt.test.ts | New test suite for Windows-safe prompt generation with good coverage, but hardcodes tool list instead of deriving from TOOL_NAMES | | src/utils/resume.ts | Clean Windows fix that bypasses multi-line prompts on cmd.exe by using single-line file reference | </details> </details> <sub>Last reviewed commit: 804354d</sub>   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-04 01:39:19 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/cli-continues#26

No description provided.

Rows
Columns