[PR #407] [MERGED] bugfix #405 on v0.3.x #937

Closed
opened 2026-03-03 01:06:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/407
Author: @fudiwei
Created: 1/8/2025
Status: Merged
Merged: 1/8/2025
Merged by: @usual2970

Base: nextHead: feat/new-workflow-ui


📝 Commits (2)

  • 0f772d5 refactor(ui): clean code
  • eb3fec1 fix: incorrect nil check logic in tencentcloud cdn and ecdn deployment

📊 Changes

17 files changed (+19 additions, -19 deletions)

View changed files

📝 internal/deployer/providers.go (+1 -1)
📝 internal/domain/provider.go (+1 -1)
📝 internal/pkg/core/deployer/providers/tencentcloud-cdn/tencentcloud_cdn.go (+1 -1)
📝 internal/pkg/core/deployer/providers/tencentcloud-ecdn/tencentcloud_ecdn.go (+1 -1)
📝 ui/src/components/workflow/node/ApplyNodeConfigForm.tsx (+2 -2)
📝 ui/src/components/workflow/node/DeployNodeConfigFormAliyunCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormAliyunDCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormAliyunOSSConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormBaiduCloudCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormBytePlusCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormQiniuCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudCLBConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudECDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormVolcEngineCDNConfig.tsx (+1 -1)
📝 ui/src/components/workflow/node/DeployNodeConfigFormVolcEngineLiveConfig.tsx (+1 -1)
📝 ui/src/utils/validators.ts (+2 -2)

📄 Description

该 PR 包含以下内容变更:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/407 **Author:** [@fudiwei](https://github.com/fudiwei) **Created:** 1/8/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@usual2970](https://github.com/usual2970) **Base:** `next` ← **Head:** `feat/new-workflow-ui` --- ### 📝 Commits (2) - [`0f772d5`](https://github.com/certimate-go/certimate/commit/0f772d55abc00c7aa29eb862290d74701ba8aee6) refactor(ui): clean code - [`eb3fec1`](https://github.com/certimate-go/certimate/commit/eb3fec1ac06e7c120db37c6623f24b664c90c653) fix: incorrect nil check logic in tencentcloud cdn and ecdn deployment ### 📊 Changes **17 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `internal/deployer/providers.go` (+1 -1) 📝 `internal/domain/provider.go` (+1 -1) 📝 `internal/pkg/core/deployer/providers/tencentcloud-cdn/tencentcloud_cdn.go` (+1 -1) 📝 `internal/pkg/core/deployer/providers/tencentcloud-ecdn/tencentcloud_ecdn.go` (+1 -1) 📝 `ui/src/components/workflow/node/ApplyNodeConfigForm.tsx` (+2 -2) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormAliyunCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormAliyunDCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormAliyunOSSConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormBaiduCloudCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormBytePlusCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormQiniuCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudCLBConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormTencentCloudECDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormVolcEngineCDNConfig.tsx` (+1 -1) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormVolcEngineLiveConfig.tsx` (+1 -1) 📝 `ui/src/utils/validators.ts` (+2 -2) </details> ### 📄 Description 该 PR 包含以下内容变更: - **fix**: 关闭 #405 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 01:06:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/certimate#937
No description provided.