[PR #797] [MERGED] fix: correct certificate expiration check logic #1042

New issue

Closed

opened 2026-03-03 01:07:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:07:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/797
Author: @usual2970
Created: 6/14/2025
Status: ✅ Merged
Merged: 6/15/2025
Merged by: @fudiwei

Base: main ← Head: hotfix/cer_expire

📝 Commits (2)

3d680e5 fix: correct certificate expiration check logic
1d4e048 refactor code

📊 Changes

4 files changed (+14 additions, -4 deletions)

View changed files

📝 ui/src/i18n/locales/en/nls.certificate.json (+1 -0)
📝 ui/src/i18n/locales/zh/nls.certificate.json (+1 -0)
📝 ui/src/pages/certificates/CertificateList.tsx (+11 -3)
📝 ui/src/repository/certificate.ts (+1 -1)

📄 Description

问题

当前证书是否过期以天为维度进行比较，会导致剩余时间不足1天但尚未过期的证书显示为已过期。
筛选即将过期证书时，会展示已过期的证书。

解决方案

精确对比，对于不足1天的证书展示剩余小时数。
筛选即将过期证书的时候，过滤掉已过期证书。

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/797 **Author:** [@usual2970](https://github.com/usual2970) **Created:** 6/14/2025 **Status:** ✅ Merged **Merged:** 6/15/2025 **Merged by:** [@fudiwei](https://github.com/fudiwei) **Base:** `main` ← **Head:** `hotfix/cer_expire` --- ### 📝 Commits (2) - [`3d680e5`](https://github.com/certimate-go/certimate/commit/3d680e50e241b8f866d592527e2e21a1fae84d52) fix: correct certificate expiration check logic - [`1d4e048`](https://github.com/certimate-go/certimate/commit/1d4e048777585d54693758ec6495595ce3ebdb00) refactor code ### 📊 Changes **4 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/i18n/locales/en/nls.certificate.json` (+1 -0) 📝 `ui/src/i18n/locales/zh/nls.certificate.json` (+1 -0) 📝 `ui/src/pages/certificates/CertificateList.tsx` (+11 -3) 📝 `ui/src/repository/certificate.ts` (+1 -1) </details> ### 📄 Description # 问题 1. 当前证书是否过期以天为维度进行比较，会导致剩余时间不足1天但尚未过期的证书显示为已过期。 2. 筛选即将过期证书时，会展示已过期的证书。 # 解决方案 1. 精确对比，对于不足1天的证书展示剩余小时数。 2. 筛选即将过期证书的时候，过滤掉已过期证书。 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>