mirror of
https://github.com/certera-io/certera.git
synced 2026-04-25 03:05:52 +03:00
[GH-ISSUE #21] Notifications not sent but test email is working (when Alternative Email field is filled in) #21
Labels
No labels
bug
feature-request
feature-request
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/certera#21
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gik000 on GitHub (Jan 5, 2021).
Original GitHub issue: https://github.com/certera-io/certera/issues/21
The notifications are not sent, but I can successfully receive the test email.
That is very strange.
The only think I can suppose about it is that we are not working under SSL connection (to the mail server).
@certeraio commented on GitHub (Jan 11, 2021):
That is indeed strange. If you can receive a test email, you should definitely be getting the other notifications. Can you confirm the SMTP configuration on the "Settings" page, please? Also can you provide a screenshot of your Notifications page (should it not contain a Slack Webhook URL), please?
@gik000 commented on GitHub (Jun 9, 2021):
The problem is when you set alternative emails.
If there is only one mail (i.e. in "Recipients" field), everything works fine,
on the other hand if you put 2 email in "Additional Recipients" (I tested with 2 addresses),
whether are " ; " separated or ";" (with no space between) the notification is not send.
@certeraio commented on GitHub (Jun 9, 2021):
Hmm, that's really strange. I'll try it out more now that there are some clear scenarios to test out.
The code that does the sending is this: https://github.com/certera-io/certera/blob/master/src/Certera.Core/Notifications/MailSender.cs#L29
Sending from the settings/test page is this: https://github.com/certera-io/certera/blob/master/src/Certera.Web/Pages/Settings/Index.cshtml.cs#L90-L92
There's something there to account for commas and semicolon delimiters.
The code that sends expirations is here: https://github.com/certera-io/certera/blob/master/src/Certera.Web/Services/NotificationService.cs#L234-L236
It also has comma and semicolon delimiter handling.
Anyways, I'll try it out and see if I can reproduce the problem on my end.