[PR #426] [MERGED] proposal: math: Go 2: use explicit types for limit constants #743

Closed
opened 2026-03-02 06:05:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/426
Author: @assimon
Created: 3/29/2022
Status: Merged
Merged: 3/29/2022
Merged by: @hibiken

Base: masterHead: master


📝 Commits (1)

  • 2e17760 proposal: math: Go 2: use explicit types for limit constants

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 internal/rdb/rdb.go (+4 -4)

📄 Description

math: MaxInt64 overflows int on ARM,

WX20220329-101458

Refer to this issue:
https://github.com/golang/go/issues/23087

math.MaxInt64 and friends are untyped constants. This causes confusion when using the constants on 32-bit systems.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/426 **Author:** [@assimon](https://github.com/assimon) **Created:** 3/29/2022 **Status:** ✅ Merged **Merged:** 3/29/2022 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2e17760`](https://github.com/hibiken/asynq/commit/2e177601ee870e14148a3618e92d416881272663) proposal: math: Go 2: use explicit types for limit constants ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/rdb/rdb.go` (+4 -4) </details> ### 📄 Description math: MaxInt64 overflows int on ARM, ![WX20220329-101458](https://user-images.githubusercontent.com/35057561/160519098-a9da1cdd-a3d4-4a24-a822-00617f11d56e.png) Refer to this issue: https://github.com/golang/go/issues/23087 math.MaxInt64 and friends are untyped constants. This causes confusion when using the constants on 32-bit systems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 06:05:25 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynq#743
No description provided.