[PR #743] [MERGED] Archived tasks that are trimmed from the set are deleted #1860

New issue

Closed

opened 2026-03-07 22:13:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:13:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/743
Author: @Harrison-Miller
Created: 9/19/2023
Status: ✅ Merged
Merged: 10/19/2024
Merged by: @kamikazechaser

Base: master ← Head: trimmed_archive_deletes

📝 Commits (3)

a2296fd fixed trimmed archive tasks not being deleted.
39b01d3 improved test case.
cd5c4f2 changed ZRANGEBYSCORE to ZRANGE with BYSCORE option.

📊 Changes

2 files changed (+175 additions, -3 deletions)

View changed files

📝 internal/rdb/rdb.go (+18 -2)
📝 internal/rdb/rdb_test.go (+157 -1)

📄 Description

Solves the issue outlined in: https://github.com/hibiken/asynq/issues/730

You can confirm the test case/fix is working by deleting lines: 852/860 in rdb.go of the fix branch to observe the old failure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/743 **Author:** [@Harrison-Miller](https://github.com/Harrison-Miller) **Created:** 9/19/2023 **Status:** ✅ Merged **Merged:** 10/19/2024 **Merged by:** [@kamikazechaser](https://github.com/kamikazechaser) **Base:** `master` ← **Head:** `trimmed_archive_deletes` --- ### 📝 Commits (3) - [`a2296fd`](https://github.com/hibiken/asynq/commit/a2296fd5cfc89f61272fbd9d25f57921c06292a7) fixed trimmed archive tasks not being deleted. - [`39b01d3`](https://github.com/hibiken/asynq/commit/39b01d3563bee8b235fab697f31145556a9a3855) improved test case. - [`cd5c4f2`](https://github.com/hibiken/asynq/commit/cd5c4f2b9098e65b3ed740ef3e906efa66b7692b) changed ZRANGEBYSCORE to ZRANGE with BYSCORE option. ### 📊 Changes **2 files changed** (+175 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/rdb/rdb.go` (+18 -2) 📝 `internal/rdb/rdb_test.go` (+157 -1) </details> ### 📄 Description Solves the issue outlined in: https://github.com/hibiken/asynq/issues/730 You can confirm the test case/fix is working by deleting lines: 852/860 in rdb.go of the fix branch to observe the old failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:13:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1860

No description provided.

Rows
Columns