[GH-ISSUE #21] Review recorded file before uploading #21

Closed
opened 2026-02-25 20:32:17 +03:00 by kerem · 9 comments
Owner

Originally created by @ku1ik on GitHub (Oct 11, 2012).
Original GitHub issue: https://github.com/asciinema/asciinema/issues/21

Some people are interested in reviewing the whole recorded output before uploading.

At the moment after recording there's question displayed:

Do you want to upload? [Y/n]

We can change it to:

y - upload, v - view recorded text, q - quit. [Y/v/q]?

Entering "v" would open the whole recorded text in less. Quitting less would
print above prompt again allowing you to upload/review/quit.

Thoughts?

Originally created by @ku1ik on GitHub (Oct 11, 2012). Original GitHub issue: https://github.com/asciinema/asciinema/issues/21 Some people are interested in reviewing the whole recorded output before uploading. At the moment after recording there's question displayed: ``` Do you want to upload? [Y/n] ``` We can change it to: ``` y - upload, v - view recorded text, q - quit. [Y/v/q]? ``` Entering "v" would open the whole recorded text in `less`. Quitting `less` would print above prompt again allowing you to upload/review/quit. Thoughts?
kerem closed this issue 2026-02-25 20:32:17 +03:00
Author
Owner

@losingkeys commented on GitHub (Oct 11, 2012):

maybe we could use scriptreplay to play it locally too? (other than just viewing it with less). I'm not sure how they're being saved currently

<!-- gh-comment-id:9359050 --> @losingkeys commented on GitHub (Oct 11, 2012): maybe we could use `scriptreplay` to play it locally too? (other than just viewing it with `less`). I'm not sure how they're being saved currently
Author
Owner

@ku1ik commented on GitHub (Oct 11, 2012):

@joshuarh well, there's no scriptreplay on OSX (which I support).

<!-- gh-comment-id:9362304 --> @ku1ik commented on GitHub (Oct 11, 2012): @joshuarh well, there's no scriptreplay on OSX (which I support).
Author
Owner

@losingkeys commented on GitHub (Oct 11, 2012):

how is OSX supported? (out of curiosity) if their script command is crippled (as it says in the ascii.io README). Also, this could be like the web, where you check if scriptreplay is supported, and provide it as an option, and only provide less if not.

<!-- gh-comment-id:9362407 --> @losingkeys commented on GitHub (Oct 11, 2012): how is OSX supported? (out of curiosity) if their `script` command is crippled (as it says in the [ascii.io README](https://github.com/sickill/ascii.io#requirements)). Also, this could be like the web, where you check if `scriptreplay` is supported, and provide it as an option, and only provide `less` if not.
Author
Owner

@ku1ik commented on GitHub (Oct 12, 2012):

@joshuarh asciiio recorder doesn't use script command on any OS. It implements the functionality of script (running shell/command in pseudo-terminal and saving stdout to file) itself.

<!-- gh-comment-id:9379874 --> @ku1ik commented on GitHub (Oct 12, 2012): @joshuarh asciiio recorder doesn't use script command on any OS. It implements the functionality of script (running shell/command in pseudo-terminal and saving stdout to file) itself.
Author
Owner

@losingkeys commented on GitHub (Oct 13, 2012):

ahh, gotcha

<!-- gh-comment-id:9406666 --> @losingkeys commented on GitHub (Oct 13, 2012): ahh, gotcha
Author
Owner

@ku1ik commented on GitHub (Mar 13, 2013):

Another option is to replay it inside of a terminal. This will be easy to implement once we have "play" subcommand (#23).

<!-- gh-comment-id:14873243 --> @ku1ik commented on GitHub (Mar 13, 2013): Another option is to replay it inside of a terminal. This will be easy to implement once we have "play" subcommand (#23).
Author
Owner

@ku1ik commented on GitHub (Nov 25, 2013):

I have created a new MR that will cover "new workflow" implementation: #49. It also covers this issue.

<!-- gh-comment-id:29249305 --> @ku1ik commented on GitHub (Nov 25, 2013): I have created a new MR that will cover "new workflow" implementation: #49. It also covers this issue.
Author
Owner

@ku1ik commented on GitHub (Dec 19, 2014):

Most probably we'll go this path: asciinema rec <filename> + asciinema play <filename> + asciinema upload <filename>. Data format is discussed in #70.

<!-- gh-comment-id:67682218 --> @ku1ik commented on GitHub (Dec 19, 2014): Most probably we'll go this path: `asciinema rec <filename>` + `asciinema play <filename>` + `asciinema upload <filename>`. Data format is discussed in #70.
Author
Owner

@ku1ik commented on GitHub (Feb 27, 2015):

This has been implemented in #80.

<!-- gh-comment-id:76363698 --> @ku1ik commented on GitHub (Feb 27, 2015): This has been implemented in #80.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asciinema#21
No description provided.