[PR #270] [CLOSED] Compile FrontEnd as part of building the Docker image #296

New issue

Closed

opened 2026-02-27 15:56:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:56:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/RD17/ambar/pull/270
Author: @james-jra
Created: 10/26/2019
Status: ❌ Closed

Base: master ← Head: multistage-frontend-docker-build

📝 Commits (1)

08280e7 Update FrontEnd Docker build to compile source

📊 Changes

2 files changed (+8 additions, -10 deletions)

View changed files

📝 FrontEnd/Dockerfile (+8 -2)
📝 README.md (+0 -8)

📄 Description

Previously, the builder must compile the FrontEnd locally before building the Docker image.

This change moves to a multi-stage Docker build for the FrontEnd: The first stage compiles the FrontEnd code, the second stage packages the build code into the existing nginx-based image.

Also removes relevant documentation for building locally from the Readme.

I know #256 #247 were already marked as "fixed", but I think this approach provides a more consistent approach with building the other application container images.

Now simply build the container image with cd FrontEnd && docker build .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RD17/ambar/pull/270 **Author:** [@james-jra](https://github.com/james-jra) **Created:** 10/26/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `multistage-frontend-docker-build` --- ### 📝 Commits (1) - [`08280e7`](https://github.com/RD17/ambar/commit/08280e70e2c44d10fe06e66b6e58a673b6700d09) Update FrontEnd Docker build to compile source ### 📊 Changes **2 files changed** (+8 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `FrontEnd/Dockerfile` (+8 -2) 📝 `README.md` (+0 -8) </details> ### 📄 Description Previously, the builder must compile the FrontEnd locally before building the Docker image. This change moves to a multi-stage Docker build for the FrontEnd: The first stage compiles the FrontEnd code, the second stage packages the build code into the existing nginx-based image. Also removes relevant documentation for building locally from the Readme. I know #256 #247 were already marked as "fixed", but I think this approach provides a more consistent approach with building the other application container images. Now simply build the container image with `cd FrontEnd && docker build .` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>