mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[GH-ISSUE #1032] Issue: Proxy not detected #599
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#599
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @caniko on GitHub (Mar 10, 2022).
Original GitHub issue: https://github.com/nektos/act/issues/1032
System information
actversion: 0.2.25Expected behaviour
Actual behaviour
Proxy should be detected from my environment variables in
/etc/environemnt.FYI
I don't have this issue when I run
dockerand/orminikube, butdocker-compose.Workflow
Steps to reproduce
Run
actbehind proxy@KnisterPeter commented on GitHub (Mar 28, 2022):
@caniko I don't think it's a bug but more a missing feature. Thanks for reporting.
@caniko commented on GitHub (Mar 28, 2022):
Please get your definitions right. It is a bug.
@catthehacker commented on GitHub (Mar 28, 2022):
Hi, it is not a bug. For it to be a bug, we would have to consider local environment (where
actis executed), which we do not, and as you might think it is undesired behaviour, it's not that, simply because we never supported proxies.A bug is a flaw in code, a mistake made by the one who have written the source code (according to your definition) but there never was a mistake of not adding proxy support.
You can currently pass
HTTP_PROXY/HTTPS_PROXYvia--env/--env-fileif needed as a workaround.@caniko commented on GitHub (Mar 29, 2022):
As a thought experiment, imagine selling a product, and using the same logic. Do you still think that it is not a bug?
Furthermore, the workaround changes the entire narrative. Thank you.
@KnisterPeter commented on GitHub (Mar 29, 2022):
Unbelievable. This is free software.
Implement and contribute if you need it!
@caniko commented on GitHub (Mar 29, 2022):
We were having an argument over semantics, and not the merits of free software.
@KnisterPeter commented on GitHub (Mar 29, 2022):
You are nitpicking. As I've said, if you want to have proxy support you can implement it.
It is a missing features as it was never on our roadmap and there is no short term plan to implement it. We simply don't have the capacity and the need to.
@caniko commented on GitHub (Mar 29, 2022):
Did you read my last message before closing the issue? I implied that the
--envmethod is fine for me.@KnisterPeter commented on GitHub (Mar 29, 2022):
Just to make this even more obvious: you closed the issue 😉
@helozjisky commented on GitHub (May 29, 2022):
Put this in ~/.actrc should work correctly
--env http_proxy=http://{ip:port}
--env https_proxy=http://{ip:port}
.actrclocations and default image survey #1517