[PR #600] [MERGED] Refactor .actrc locations and default image survey #1517

Closed
opened 2026-03-01 21:51:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/600
Author: @catthehacker
Created: 4/3/2021
Status: Merged
Merged: 4/5/2021
Merged by: @cplee

Base: masterHead: xdg-config


📝 Commits (2)

  • 6dd56ee refactor: move survey/cfgs into own funcs, read XDG base dirs for config
  • 40ee9bc refactor: use go-homedir, check if XDG var is not empty

📊 Changes

4 files changed (+96 additions, -107 deletions)

View changed files

📝 cmd/root.go (+79 -47)
📝 go.mod (+1 -3)
📝 go.sum (+0 -44)
📝 pkg/runner/run_context.go (+16 -13)

📄 Description

Fixes #599

Moved actrc locations to own func since it can be reused.
Moved survey part to own func due to high cyclomatic complexity.
Added XDG config dir to config locations.
Replaced using HOME envvar with go-homedir module since it's already
an indirect dependency and handles home directories better for each GOOS.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/600 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 4/3/2021 **Status:** ✅ Merged **Merged:** 4/5/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `xdg-config` --- ### 📝 Commits (2) - [`6dd56ee`](https://github.com/nektos/act/commit/6dd56eee173e4a1b5a966c979543c5d66059b108) refactor: move survey/cfgs into own funcs, read XDG base dirs for config - [`40ee9bc`](https://github.com/nektos/act/commit/40ee9bc642e78c612c37a39566b14c5437fbde4d) refactor: use `go-homedir`, check if XDG var is not empty ### 📊 Changes **4 files changed** (+96 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+79 -47) 📝 `go.mod` (+1 -3) 📝 `go.sum` (+0 -44) 📝 `pkg/runner/run_context.go` (+16 -13) </details> ### 📄 Description Fixes #599 Moved actrc locations to own func since it can be reused. Moved survey part to own func due to high cyclomatic complexity. Added XDG config dir to config locations. Replaced using HOME envvar with `go-homedir` module since it's already an indirect dependency and handles home directories better for each GOOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1517
No description provided.