mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[GH-ISSUE #586] Issue: Unable to build latest act due to docker daemon API version 1.41 #390
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#390
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jaypipes on GitHub (Mar 29, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/586
Act version
af5140f13e25a304cba8d3ac8646342440fc2ad6commit, also tested withv0.2.20(see notes below).Docker version:
Expected behaviour
Be able to build with docker daemon 1.40 and earlier by switching off container image platform discovery on versions that don't support it.
Actual behaviour
I
git clone'd the act repo at commitaf5140f13e25a304cba8d3ac8646342440fc2ad6and rango run main.go:Note: If you run
make testit will just hang forever with no output until you Ctrl-C to stop it, and then you'll note a bunch of errors like this:I noticed that a recent commit updated the docker dependency from
v17.12.0-ce-rc1.0.20200618181300-9dc6525e6118+incompatibletov20.10.3+incompatibleand so figured I would check out the latest release tag (v0.2.20) and re-rango run main.gowhich got me past the "specify container image platform requires API version 1.41" error.If
actis going to depend on really modern versions of Docker, I think that should be listed in the README as a dependency, otherwise consider adding features like container image platform discovery behind some "check and see if my docker daemon supports this yet"-type conditionals?If you are OK with the latter conditional checks being added to
act, I can submit some code for that.Best,
-jay
@catthehacker commented on GitHub (Mar 29, 2021):
Sorry for breaking stuff 😔 supporting older and current Docker API would be definitely best option although I'm not sure if it's possible to do. Feel free to submit PR.
@jaypipes commented on GitHub (Mar 29, 2021):
No need to apologize at all! :)
I'll work on a PR and submit shortly.
@cplee commented on GitHub (Mar 29, 2021):
Thanks for bringing attention to this @jaypipes ... and for offering to help!