[PR #1845] [MERGED] Allow inputs for workflow_calls #2157

Closed
opened 2026-03-01 21:54:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1845
Author: @GuessWhoSamFoo
Created: 6/5/2023
Status: Merged
Merged: 6/27/2023
Merged by: @mergify[bot]

Base: masterHead: issue-1542


📝 Commits (2)

  • b1c986b Allow inputs for workflow_calls
  • 7221a2d Merge branch 'master' into issue-1542

📊 Changes

4 files changed (+60 additions, -0 deletions)

View changed files

📝 pkg/runner/expression.go (+17 -0)
📝 pkg/runner/runner_test.go (+1 -0)
pkg/runner/testdata/workflow_call_inputs/event.json (+6 -0)
pkg/runner/testdata/workflow_call_inputs/workflow_call_inputs.yml (+36 -0)

📄 Description

Fixes #1542

There's likely room to deduplicate some code in the future with generics once https://github.com/golang/go/issues/48522 gets in a better spot since WorkflowDispatchConfig and WorkflowCallConfig is iterating through inputs on shared fields. Embedding is also possible here although it would require a much larger refactor also not much gained imo.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1845 **Author:** [@GuessWhoSamFoo](https://github.com/GuessWhoSamFoo) **Created:** 6/5/2023 **Status:** ✅ Merged **Merged:** 6/27/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `issue-1542` --- ### 📝 Commits (2) - [`b1c986b`](https://github.com/nektos/act/commit/b1c986b574c518bcb1554e15a5443caced8bb09d) Allow inputs for workflow_calls - [`7221a2d`](https://github.com/nektos/act/commit/7221a2dc0e0558e5c08ebfaf0d9bf07ba8a6b658) Merge branch 'master' into issue-1542 ### 📊 Changes **4 files changed** (+60 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+17 -0) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/workflow_call_inputs/event.json` (+6 -0) ➕ `pkg/runner/testdata/workflow_call_inputs/workflow_call_inputs.yml` (+36 -0) </details> ### 📄 Description Fixes #1542 There's likely room to deduplicate some code in the future with generics once https://github.com/golang/go/issues/48522 gets in a better spot since `WorkflowDispatchConfig` and `WorkflowCallConfig` is iterating through inputs on shared fields. Embedding is also possible here although it would require a much larger refactor also not much gained imo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:54:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2157
No description provided.