mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[PR #1845] [MERGED] Allow inputs for workflow_calls #2157
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#2157
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/1845
Author: @GuessWhoSamFoo
Created: 6/5/2023
Status: ✅ Merged
Merged: 6/27/2023
Merged by: @mergify[bot]
Base:
master← Head:issue-1542📝 Commits (2)
b1c986bAllow inputs for workflow_calls7221a2dMerge branch 'master' into issue-1542📊 Changes
4 files changed (+60 additions, -0 deletions)
View changed files
📝
pkg/runner/expression.go(+17 -0)📝
pkg/runner/runner_test.go(+1 -0)➕
pkg/runner/testdata/workflow_call_inputs/event.json(+6 -0)➕
pkg/runner/testdata/workflow_call_inputs/workflow_call_inputs.yml(+36 -0)📄 Description
Fixes #1542
There's likely room to deduplicate some code in the future with generics once https://github.com/golang/go/issues/48522 gets in a better spot since
WorkflowDispatchConfigandWorkflowCallConfigis iterating through inputs on shared fields. Embedding is also possible here although it would require a much larger refactor also not much gained imo.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.