[PR #660] [MERGED] Remove pwsh -login and add Pwsh test #1542

New issue

Closed

opened 2026-03-01 21:51:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/660
Author: @JustinGrote
Created: 5/4/2021
Status: ✅ Merged
Merged: 5/5/2021
Merged by: @mergify[bot]

Base: master ← Head: JustinGrote/fixPwshAndTest

📝 Commits (5)

1a7d5ab Remove pwsh -login and add Pwsh test
81ba210 Add Shell Command Test for coverage
a91679c 🧪 Move PWSH Platform definition to inline test, it can always be expanded out later
8e108c5 Test MacOS Build for transient failure
7ebb0d9 Merge branch 'master' into JustinGrote/fixPwshAndTest

📊 Changes

3 files changed (+20 additions, -2 deletions)

View changed files

📝 pkg/model/workflow.go (+1 -1)
📝 pkg/model/workflow_test.go (+16 -0)
📝 pkg/runner/runner_test.go (+3 -1)

📄 Description

This resolves the issue with pwsh failing due to -login and the command not splitting correctly.

It also adds a test pwsh run using a image that has Powershell integrated, hopefully this doesn't introduce too much into the testing time, but the image can be cached in the CI if necessary to speed things up.

EDIT: Literally took less than half a second to download and extract the container, I guess that's a benefit of using the github container registry :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/660 **Author:** [@JustinGrote](https://github.com/JustinGrote) **Created:** 5/4/2021 **Status:** ✅ Merged **Merged:** 5/5/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `JustinGrote/fixPwshAndTest` --- ### 📝 Commits (5) - [`1a7d5ab`](https://github.com/nektos/act/commit/1a7d5abf3923e1df695527658940e9b2a3064fbb) Remove pwsh -login and add Pwsh test - [`81ba210`](https://github.com/nektos/act/commit/81ba2100127f7c2d37ebd18aa62f0a26fbd39229) Add Shell Command Test for coverage - [`a91679c`](https://github.com/nektos/act/commit/a91679c83c55128751c14c6c5bbb6bdaf02c413c) 🧪 Move PWSH Platform definition to inline test, it can always be expanded out later - [`8e108c5`](https://github.com/nektos/act/commit/8e108c56135f8e7ee9df225c23a426bea08490e8) Test MacOS Build for transient failure - [`7ebb0d9`](https://github.com/nektos/act/commit/7ebb0d9c82daae1393717e15db20a02b6e2694e2) Merge branch 'master' into JustinGrote/fixPwshAndTest ### 📊 Changes **3 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+1 -1) 📝 `pkg/model/workflow_test.go` (+16 -0) 📝 `pkg/runner/runner_test.go` (+3 -1) </details> ### 📄 Description This resolves the issue with pwsh failing due to -login and the command not splitting correctly. It also adds a test pwsh run using a image that has Powershell integrated, hopefully this doesn't introduce too much into the testing time, but the image can be cached in the CI if necessary to speed things up. EDIT: Literally took less than half a second to download and extract the container, I guess that's a benefit of using the github container registry :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:37 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:15 +03:00

[PR #1845] [MERGED] Allow inputs for workflow_calls #2157

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1542

No description provided.

Rows
Columns