[PR #1619] [MERGED] fix: tolerate workflow that needs a missing job (#1595) #2035

New issue

Closed

opened 2026-03-01 21:53:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1619
Author: @jsoref
Created: 2/8/2023
Status: ✅ Merged
Merged: 2/16/2023
Merged by: @mergify[bot]

Base: master ← Head: issue-1595

📝 Commits (3)

173f6d8 Make linter happy
d64f278 Change planner functions to return errors
b14fb1b Merge branch 'master' into issue-1595

📊 Changes

9 files changed (+238 additions, -48 deletions)

View changed files

📝 cmd/root.go (+33 -10)
📝 pkg/artifacts/server_test.go (+9 -6)
📝 pkg/model/planner.go (+53 -18)
📝 pkg/model/workflow_test.go (+2 -1)
📝 pkg/runner/reusable_workflow.go (+4 -1)
📝 pkg/runner/runner_test.go (+103 -12)
➕ pkg/runner/testdata/issue-1595/missing.yml (+16 -0)
➕ pkg/runner/testdata/issue-1595/no-event.yml (+8 -0)
➕ pkg/runner/testdata/issue-1595/no-first.yml (+10 -0)

📄 Description

Try to fix #1595...

Commit Message

{{title}} (#1619)

Change planner functions to return errors

This enables createStages to return unable to build dependency graph

Fix PlanEvent to properly report errors relating to events/workflows

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1619 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 2/8/2023 **Status:** ✅ Merged **Merged:** 2/16/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `issue-1595` --- ### 📝 Commits (3) - [`173f6d8`](https://github.com/nektos/act/commit/173f6d8d114e278c02ed6cb3bf6cb957632792c9) Make linter happy - [`d64f278`](https://github.com/nektos/act/commit/d64f27894dd9a4dc98a5f6385dd724158a7ff1be) Change planner functions to return errors - [`b14fb1b`](https://github.com/nektos/act/commit/b14fb1be6c243335a3929fdc3b69043467f22d8e) Merge branch 'master' into issue-1595 ### 📊 Changes **9 files changed** (+238 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+33 -10) 📝 `pkg/artifacts/server_test.go` (+9 -6) 📝 `pkg/model/planner.go` (+53 -18) 📝 `pkg/model/workflow_test.go` (+2 -1) 📝 `pkg/runner/reusable_workflow.go` (+4 -1) 📝 `pkg/runner/runner_test.go` (+103 -12) ➕ `pkg/runner/testdata/issue-1595/missing.yml` (+16 -0) ➕ `pkg/runner/testdata/issue-1595/no-event.yml` (+8 -0) ➕ `pkg/runner/testdata/issue-1595/no-first.yml` (+10 -0) </details> ### 📄 Description Try to fix #1595... ## Commit Message {{title}} (#1619) Change planner functions to return errors This enables createStages to return `unable to build dependency graph` Fix PlanEvent to properly report errors relating to events/workflows --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2035

No description provided.

Rows
Columns