[PR #766] [MERGED] Update docs, file formatting and docker images #1595

New issue

Closed

opened 2026-03-01 21:51:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/766
Author: @catthehacker
Created: 8/8/2021
Status: ✅ Merged
Merged: 8/9/2021
Merged by: @cplee

Base: master ← Head: cat/fix/docker-images

📝 Commits (8)

16540c5 docs: fix wrong licence link
240ef8f fix: add more formatting settings, reformat all
6ade04f docs: update contributing documentation
8087f2b fix: remove unnecessary comment
9276b75 docs: rework installation section
3f09f00 docs: update images provided by catthehacker
e6fbe20 docs: replace 18.04 with recent image
114c117 fix: add final new line

📊 Changes

21 files changed (+186 additions, -134 deletions)

View changed files

📝 .editorconfig (+12 -0)
📝 .github/ISSUE_TEMPLATE/feature_template.md (+1 -1)
📝 .github/ISSUE_TEMPLATE/issue_template.md (+1 -1)
📝 .github/actions/choco/action.yml (+1 -1)
📝 .github/actions/composite/action.yml (+1 -1)
📝 .github/actions/composite/script.sh (+1 -1)
📝 .github/workflows/release.yml (+1 -1)
📝 .github/workflows/stale.yml (+15 -15)
📝 .gitignore (+1 -2)
📝 .mergify.yml (+12 -12)
➕ .prettierignore (+2 -0)
➕ .prettierrc.yml (+7 -0)
➕ .vscode/extensions.json (+9 -0)
📝 .vscode/settings.json (+11 -4)
📝 CONTRIBUTING.md (+36 -34)
📝 IMAGES.md (+13 -27)
📝 LICENSE (+1 -1)
📝 Makefile (+14 -2)
📝 README.md (+43 -27)
📝 cmd/root.go (+3 -3)

...and 1 more files

📄 Description

changelog:

fixed licence link in CONTRIBUTING.md
added more settings to .editorconfig
- enforce lf
- enforce final new line
- enforce utf-8 encoding
- enforce indent width 2 and spaces in yaml, yml and json
added more VSCode settings
- added recommended extensions and default formatter to workspace that will help contributors who use VSCode
added prettier as a markdown/yaml/json formatter, but ignore testdata/ and that one bootstrap JS file
fixed linters to be used via npx in makefile
normalised quotes across Markdown/JSON/YAML via prettier, we had mixed, now we have ' in YAML, " in JSON/Markdown which is pretty common configuration everywhere
updated tag to my Docker images, as I'm dropping Docker Hub as my primary registry (I will still update images there, but since they decrease available things for free plan, I cannot consider them for any of my repositories)
I also dropped work on Alpine image (since I'm spending more time for polishing the medium-* and full-* images and dropped support for any architecture other than amd64 (because it was creating unnecessary issues for standard act users, if it happens I'll have more time, I might introduce them again but as completely separated images)
replaced ubuntu-18.04 image provided by nektos with mine, I'm trying to keep big images updated by building them at least once in a month
Reworked installation section in README.md since there were few issues highlighted about them recently. Current structure should be easier to follow.
root.go
- added final new line to each option in survey
- updated my image tags
- also fixed that one missing -P
- added ubuntu-latest/ubuntu-20.04 for large and replaced ubuntu-18.04

sorry for creating another massive PR, I just keep finding stuff to fix/improve when I'm constantly crawling repository
let me know if there is something I should drop from this PR

Issues:
fixes #765

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/766 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 8/8/2021 **Status:** ✅ Merged **Merged:** 8/9/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `cat/fix/docker-images` --- ### 📝 Commits (8) - [`16540c5`](https://github.com/nektos/act/commit/16540c509102b307971884fe9ed398c321649602) docs: fix wrong licence link - [`240ef8f`](https://github.com/nektos/act/commit/240ef8f64b51fb4a634dc84c0caa4ecb04049e15) fix: add more formatting settings, reformat all - [`6ade04f`](https://github.com/nektos/act/commit/6ade04f4f0210fe3ae12d949f9d494fd802a7ee9) docs: update contributing documentation - [`8087f2b`](https://github.com/nektos/act/commit/8087f2ba44c69962732e35f4a3f3b07a358f1967) fix: remove unnecessary comment - [`9276b75`](https://github.com/nektos/act/commit/9276b75e6aec3ce329ee3434ef3771dd0e20c862) docs: rework installation section - [`3f09f00`](https://github.com/nektos/act/commit/3f09f00cb3aed8263b745ed436964547cf2d2802) docs: update images provided by catthehacker - [`e6fbe20`](https://github.com/nektos/act/commit/e6fbe20edde146fc76611c0f0ae50433cda1e8f7) docs: replace 18.04 with recent image - [`114c117`](https://github.com/nektos/act/commit/114c11729e2d117ce6f831f4dc96b93bc45a6acd) fix: add final new line ### 📊 Changes **21 files changed** (+186 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+12 -0) 📝 `.github/ISSUE_TEMPLATE/feature_template.md` (+1 -1) 📝 `.github/ISSUE_TEMPLATE/issue_template.md` (+1 -1) 📝 `.github/actions/choco/action.yml` (+1 -1) 📝 `.github/actions/composite/action.yml` (+1 -1) 📝 `.github/actions/composite/script.sh` (+1 -1) 📝 `.github/workflows/release.yml` (+1 -1) 📝 `.github/workflows/stale.yml` (+15 -15) 📝 `.gitignore` (+1 -2) 📝 `.mergify.yml` (+12 -12) ➕ `.prettierignore` (+2 -0) ➕ `.prettierrc.yml` (+7 -0) ➕ `.vscode/extensions.json` (+9 -0) 📝 `.vscode/settings.json` (+11 -4) 📝 `CONTRIBUTING.md` (+36 -34) 📝 `IMAGES.md` (+13 -27) 📝 `LICENSE` (+1 -1) 📝 `Makefile` (+14 -2) 📝 `README.md` (+43 -27) 📝 `cmd/root.go` (+3 -3) _...and 1 more files_ </details> ### 📄 Description changelog: - fixed licence link in `CONTRIBUTING.md` - added more settings to `.editorconfig` - enforce `lf` - enforce final new line - enforce `utf-8` encoding - enforce indent width `2` and spaces in `yaml`, `yml` and `json` - added more VSCode settings - added recommended extensions and default formatter to workspace that will *help* contributors who use VSCode - added `prettier` as a markdown/yaml/json formatter, but ignore `testdata/` and that one bootstrap JS file - fixed linters to be used via `npx` in `makefile` - normalised quotes across Markdown/JSON/YAML via `prettier`, we had mixed, now we have `'` in YAML, `"` in JSON/Markdown which is pretty common configuration everywhere - updated tag to my Docker images, as I'm dropping Docker Hub as my primary registry (I will still update images there, but since they decrease available things for free plan, I cannot consider them for any of my repositories) I also dropped work on Alpine image (since I'm spending more time for polishing the `medium-*` and `full-*` images and dropped support for any architecture other than `amd64` (because it was creating unnecessary issues for standard `act` users, if it happens I'll have more time, I might introduce them again but as completely separated images) - **replaced `ubuntu-18.04` image provided by nektos with mine, I'm trying to keep big images updated by building them at least once in a month** - Reworked installation section in `README.md` since there were few issues highlighted about them recently. Current structure should be easier to follow. - `root.go` - added final new line to each option in survey - updated my image tags - also fixed that one missing `-P` ![image](https://user-images.githubusercontent.com/31106839/128618822-10d14f2d-127d-4d33-a450-2a6495517f0e.png) - added `ubuntu-latest`/`ubuntu-20.04` for large and replaced `ubuntu-18.04` sorry for creating another massive PR, I just keep finding stuff to fix/improve when I'm constantly crawling repository let me know if there is something I should drop from this PR Issues: fixes #765 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:44 +03:00

[PR #1619] [MERGED] fix: tolerate workflow that needs a missing job (#1595) #2035

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1595

No description provided.

Rows
Columns