[PR #1597] [MERGED] Update max container name length #2022

New issue

Closed

opened 2026-03-01 21:53:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1597
Author: @aidandj
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/3/2023
Merged by: @mergify[bot]

Base: master ← Head: aidan/fix-part-length

📝 Commits (4)

f70fa5b Update max container name length
cfedfe3 Merge branch 'nektos:master' into aidan/fix-part-length
108d163 Use hashed name instead to prevent conflicts
01a32de Merge branch 'master' into aidan/fix-part-length

📊 Changes

1 file changed (+10 additions, -19 deletions)

View changed files

📝 pkg/runner/run_context.go (+10 -19)

📄 Description

I think I understood this function correctly. Please chime in if I was wrong. I had an issue when running multiple jobs in parallel with long names, the container names were conflicting.

I think this function is supposed to make sure container names don't get longer than what is allowed. But container names can be up to 128 characters I believe.

Signed-off-by: Aidan Jensen aidan@artificial.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1597 **Author:** [@aidandj](https://github.com/aidandj) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/3/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `aidan/fix-part-length` --- ### 📝 Commits (4) - [`f70fa5b`](https://github.com/nektos/act/commit/f70fa5b92cb3a25da8440885ca8ec5ccf5ae7e36) Update max container name length - [`cfedfe3`](https://github.com/nektos/act/commit/cfedfe343c5284b530da5df0fbe7604bff2183bc) Merge branch 'nektos:master' into aidan/fix-part-length - [`108d163`](https://github.com/nektos/act/commit/108d163cb7c162b6e25d03a754ee532f371822a8) Use hashed name instead to prevent conflicts - [`01a32de`](https://github.com/nektos/act/commit/01a32de754aa0c70774449ea1777928d979c507e) Merge branch 'master' into aidan/fix-part-length ### 📊 Changes **1 file changed** (+10 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+10 -19) </details> ### 📄 Description I _think_ I understood this function correctly. Please chime in if I was wrong. I had an issue when running multiple jobs in parallel with long names, the container names were conflicting. I think this function is supposed to make sure container names don't get longer than what is allowed. But container names can be up to 128 characters I believe. Signed-off-by: Aidan Jensen <aidan@artificial.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:34 +03:00

[PR #2022] [MERGED] fix: image survey for large images #2235

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2022

No description provided.

Rows
Columns