mirror of
https://github.com/nektos/act.git
synced 2026-04-27 01:45:52 +03:00
[PR #768] [MERGED] Cache dockerhub images from linux for macOS #1597
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1597
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/768
Author: @ChristopherHX
Created: 8/8/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @cplee
Base:
master← Head:patch-2📝 Commits (5)
b5ade3dCache dockerhub images from linux for macOS02df67fparallelize / refactor docker cache420f358Merge branch 'master' into patch-2c4cc951Merge branch 'master' into patch-22894487Merge branch 'master' into patch-2📊 Changes
1 file changed (+55 additions, -2 deletions)
View changed files
📝
.github/workflows/checks.yml(+55 -2)📄 Description
An attempt to avoid hitting the dockerhub Pull Rate Limit.
There is a small overhead due to caching (ca. +2 min, next run within 7 days only some seconds), but it might avoid rerunning the macOS job due to this error.
Restoreing the cache doesn't take much extra job execution time, because the test step is pulling less images from dockerhub.
This PR failed due to this limit #776.
It seems to be triggered by multiple PR's are opened within some days.
Needs more testing, if this solves the dockerhub limit problems or only delays the problem to happen less frequently.
Add new dockerhub images to
CACHED_DOCKER_IMAGESand increment the cache key (CACHED_DOCKER_IMAGES_KEY)What do you think?
I need ACT_OWNER: ${{ github.repository_owner }} and ACT_REPOSITORY: ${{ github.repository }} to have all tests green within my fork
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.