mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[PR #1557] [MERGED] feat: add support for building docker actions with private registries #2001
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#2001
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/1557
Author: @ZauberNerd
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @mergify[bot]
Base:
master← Head:docker-build-authenticated📝 Commits (1)
0aff358feat: add support for building docker actions with private registries📊 Changes
2 files changed (+25 additions, -3 deletions)
View changed files
📝
pkg/container/docker_auth.go(+21 -0)📝
pkg/container/docker_build.go(+4 -3)📄 Description
This commit adds a new
LoadDockerAuthConfigsfunction, which loads all registry auths that are configured on the host and sends them with the build command to the docker daemon.This is needed in case act builds a docker action and the images referenced in that docker action are located on private registries or otherwise require authentication (e.g. to get a higher rate limit).
The code is adapted from how the docker cli works:
github.com/docker/cli@257ff41304/cli/command/image/build.go (L323-L332)🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.