[PR #680] [MERGED] Hotfix: Skip Checkout Regression #1557

New issue

Closed

opened 2026-03-01 21:51:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/680
Author: @JustinGrote
Created: 5/8/2021
Status: ✅ Merged
Merged: 5/10/2021
Merged by: @mergify[bot]

Base: master ← Head: hotfix/SkipCheckout

📝 Commits (8)

e6db7e1 Fix: Skip Checkout Regression
57735f4 Fix test name
bd086d8 Add newline to end of checkout push test
1b671b8 Restore .gitignore from node12 test. Todo: Restore that file after the test
ca47361 Format workflow
d8f079b Test: Fix path slash direction for windows relative source path
455ec8e Add explicit nil test for newRemoteAction
5ab38fa Regress .secrets during tests

📊 Changes

5 files changed (+19 additions, -12 deletions)

View changed files

📝 pkg/runner/run_context.go (+5 -1)
📝 pkg/runner/runner_test.go (+4 -6)
📝 pkg/runner/step_context.go (+1 -1)
📝 pkg/runner/step_context_test.go (+1 -4)
➕ pkg/runner/testdata/checkout/push.yml (+8 -0)

📄 Description

The testing logic for isLocalCheckout was incorrect, fix and add a test specifically for checkout.

Fixes #678

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/680 **Author:** [@JustinGrote](https://github.com/JustinGrote) **Created:** 5/8/2021 **Status:** ✅ Merged **Merged:** 5/10/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `hotfix/SkipCheckout` --- ### 📝 Commits (8) - [`e6db7e1`](https://github.com/nektos/act/commit/e6db7e1731f1859367a37ce149316d4727d9ac28) Fix: Skip Checkout Regression - [`57735f4`](https://github.com/nektos/act/commit/57735f487007a3dc5a041101ba0726ac9d19da92) Fix test name - [`bd086d8`](https://github.com/nektos/act/commit/bd086d8fbce30413392fa3cb145514f98d457417) Add newline to end of checkout push test - [`1b671b8`](https://github.com/nektos/act/commit/1b671b8f5847c8e5360a8054c2fc4b90b684d2a6) Restore .gitignore from node12 test. Todo: Restore that file after the test - [`ca47361`](https://github.com/nektos/act/commit/ca473613f530016c5d989dd955bb3db50bc45b61) Format workflow - [`d8f079b`](https://github.com/nektos/act/commit/d8f079bd8d79391fe7e38c76531e9455fd6d74ce) Test: Fix path slash direction for windows relative source path - [`455ec8e`](https://github.com/nektos/act/commit/455ec8e4fbd98419a83a9b4ef742ab0413247650) Add explicit nil test for newRemoteAction - [`5ab38fa`](https://github.com/nektos/act/commit/5ab38fab1d9ebed4ca9464da495569a87b1e237b) Regress .secrets during tests ### 📊 Changes **5 files changed** (+19 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+5 -1) 📝 `pkg/runner/runner_test.go` (+4 -6) 📝 `pkg/runner/step_context.go` (+1 -1) 📝 `pkg/runner/step_context_test.go` (+1 -4) ➕ `pkg/runner/testdata/checkout/push.yml` (+8 -0) </details> ### 📄 Description The testing logic for isLocalCheckout was incorrect, fix and add a test specifically for checkout. Fixes #678 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:36 +03:00

[PR #1557] [MERGED] feat: add support for building docker actions with private registries #2001

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1557

No description provided.

Rows
Columns