[PR #1415] [CLOSED] refactor: allow error state on conditional executor #1935

New issue

Closed

opened 2026-03-01 21:53:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1415
Author: @KnisterPeter
Created: 10/28/2022
Status: ❌ Closed

Base: master ← Head: allow-error-on-conditional

📝 Commits (1)

2a34acd refactor: allow error state on conditional executor

📊 Changes

10 files changed (+72 additions, -33 deletions)

View changed files

📝 pkg/common/dryrun.go (+3 -3)
📝 pkg/common/executor.go (+22 -8)
📝 pkg/common/executor_test.go (+4 -4)
📝 pkg/container/docker_build.go (+5 -1)
📝 pkg/container/docker_pull.go (+5 -1)
📝 pkg/container/docker_run.go (+5 -1)
📝 pkg/container/docker_volume.go (+5 -1)
📝 pkg/runner/action.go (+12 -12)
📝 pkg/runner/logger.go (+6 -1)
📝 pkg/runner/step_action_local.go (+5 -1)

📄 Description

The conditional executor should be able to handle
an error during conditional evaluation.
Not being able to abort execution in case of an error is a severe limitation which complicates using code by opt-out of executor chaining.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1415 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 10/28/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `allow-error-on-conditional` --- ### 📝 Commits (1) - [`2a34acd`](https://github.com/nektos/act/commit/2a34acd0246d6db69390820e46475f4ac87d9144) refactor: allow error state on conditional executor ### 📊 Changes **10 files changed** (+72 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `pkg/common/dryrun.go` (+3 -3) 📝 `pkg/common/executor.go` (+22 -8) 📝 `pkg/common/executor_test.go` (+4 -4) 📝 `pkg/container/docker_build.go` (+5 -1) 📝 `pkg/container/docker_pull.go` (+5 -1) 📝 `pkg/container/docker_run.go` (+5 -1) 📝 `pkg/container/docker_volume.go` (+5 -1) 📝 `pkg/runner/action.go` (+12 -12) 📝 `pkg/runner/logger.go` (+6 -1) 📝 `pkg/runner/step_action_local.go` (+5 -1) </details> ### 📄 Description The conditional executor should be able to handle an error during conditional evaluation. Not being able to abort execution in case of an error is a severe limitation which complicates using code by opt-out of executor chaining. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1935

No description provided.

Rows
Columns