[PR #343] [MERGED] Support setting shell via defaults.run #1415

New issue

Closed

opened 2026-03-01 21:51:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/343
Author: @tokenrove
Created: 8/21/2020
Status: ✅ Merged
Merged: 8/28/2020
Merged by: @cplee

Base: master ← Head: add-defaults-run

📝 Commits (2)

a8c59af Support setting shell via defaults.run
9b38460 Merge branch 'master' into add-defaults-run

📊 Changes

4 files changed (+60 additions, -4 deletions)

View changed files

📝 pkg/model/workflow.go (+17 -4)
📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_context.go (+13 -0)
➕ pkg/runner/testdata/defaults-run/main.yaml (+29 -0)

📄 Description

I encountered this while testing a workflow for an image without bash. I added this quickly to unblock myself, but please let me know if you'd like me to change the approach; I didn't think too much about what would be idiomatic. Also, thanks a lot for this useful tool.

I believe this fixes #214.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/343 **Author:** [@tokenrove](https://github.com/tokenrove) **Created:** 8/21/2020 **Status:** ✅ Merged **Merged:** 8/28/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `add-defaults-run` --- ### 📝 Commits (2) - [`a8c59af`](https://github.com/nektos/act/commit/a8c59af67f9fe420deda6c768dc3433a48366302) Support setting shell via defaults.run - [`9b38460`](https://github.com/nektos/act/commit/9b3846082afcc48720764841331866a602b1cf7c) Merge branch 'master' into add-defaults-run ### 📊 Changes **4 files changed** (+60 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+17 -4) 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_context.go` (+13 -0) ➕ `pkg/runner/testdata/defaults-run/main.yaml` (+29 -0) </details> ### 📄 Description I encountered this while testing a workflow for an image without bash. I added this quickly to unblock myself, but please let me know if you'd like me to change the approach; I didn't think too much about what would be idiomatic. Also, thanks a lot for this useful tool. I believe this fixes #214. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:19 +03:00

[PR #1415] [CLOSED] refactor: allow error state on conditional executor #1935

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1415

No description provided.

Rows
Columns