[PR #1208] [MERGED] Added support for chunked uploads. #1840

New issue

Closed

opened 2026-03-01 21:52:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1208
Author: @grigorye
Created: 6/10/2022
Status: ✅ Merged
Merged: 6/20/2022
Merged by: @cplee

Base: master ← Head: feature/Chunked-Uploads-With-Multiple-Requests

📝 Commits (4)

40ecfd7 Added tests for mid-size and big artifacts, reproducing a problem with chunked uploads.
7bda6b5 Added support for chunked uploads.
b6ae8b2 Enforced overwriting uploaded artifacts on receiving the first chunk.
bb420d1 Merge branch 'master' into feature/Chunked-Uploads-With-Multiple-Requests

📊 Changes

3 files changed (+126 additions, -3 deletions)

View changed files

📝 pkg/artifacts/server.go (+25 -2)
📝 pkg/artifacts/server_test.go (+10 -0)
📝 pkg/artifacts/testdata/upload-and-download/artifacts.yml (+91 -1)

📄 Description

This is follow-up for https://github.com/nektos/act/pull/1206, eventually addressing https://github.com/nektos/act/pull/677#discussion_r633667121.

It implements a naive handler that just appends every chunk, assuming that upload-artifact does the chunk upload sequentially.

It passes the tests introduced for chunked uploads, that were failing in #1206, so I wonder if it might be enough for starters.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1208 **Author:** [@grigorye](https://github.com/grigorye) **Created:** 6/10/2022 **Status:** ✅ Merged **Merged:** 6/20/2022 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `feature/Chunked-Uploads-With-Multiple-Requests` --- ### 📝 Commits (4) - [`40ecfd7`](https://github.com/nektos/act/commit/40ecfd79b1f013a74e1298407858036f101da97a) Added tests for mid-size and big artifacts, reproducing a problem with chunked uploads. - [`7bda6b5`](https://github.com/nektos/act/commit/7bda6b5933eac127ebca46f57f6432555b36555a) Added support for chunked uploads. - [`b6ae8b2`](https://github.com/nektos/act/commit/b6ae8b293f6ebec755a64a2a5dfa8c459cb51d03) Enforced overwriting uploaded artifacts on receiving the first chunk. - [`bb420d1`](https://github.com/nektos/act/commit/bb420d1cf11a38bb724835a32e92dd25c94127ef) Merge branch 'master' into feature/Chunked-Uploads-With-Multiple-Requests ### 📊 Changes **3 files changed** (+126 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/artifacts/server.go` (+25 -2) 📝 `pkg/artifacts/server_test.go` (+10 -0) 📝 `pkg/artifacts/testdata/upload-and-download/artifacts.yml` (+91 -1) </details> ### 📄 Description This is follow-up for https://github.com/nektos/act/pull/1206, eventually addressing https://github.com/nektos/act/pull/677#discussion_r633667121. It implements a naive handler that just appends every chunk, assuming that upload-artifact [does the chunk upload sequentially](https://github.com/actions/upload-artifact/blob/3cea5372237819ed00197afe530f5a7ea3e805c8/dist/index.js#L7683-L7739). It passes the tests introduced for chunked uploads, that were failing in #1206, so I wonder if it might be enough for starters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:14 +03:00

[PR #1840] [MERGED] build(deps): bump github.com/imdario/mergo from 0.3.15 to 0.3.16 #2153

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1840

No description provided.

Rows
Columns