mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[PR #591] [MERGED] use container image platform only on docker 1.41+ #1512
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1512
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/591
Author: @jaypipes
Created: 3/30/2021
Status: ✅ Merged
Merged: 3/30/2021
Merged by: @cplee
Base:
master← Head:issue586📝 Commits (1)
9c15e50use container image platform only on docker 1.41+📊 Changes
5 files changed (+36 additions, -10 deletions)
View changed files
📝
README.md(+1 -1)📝
cmd/root.go(+1 -1)📝
go.mod(+1 -0)📝
go.sum(+1 -0)📝
pkg/container/docker_run.go(+32 -8)📄 Description
Commit
af5140f13eintroduced support forspecifying a container image platform for cross-platform image building.
Unfortunately, attempting to execute a docker command that includes the
--platformflag against Docker daemons using API Version 1.40 andbefore results in the following error:
To allow
actto be used on the 19.03 Docker CE and earlier versions,this patch simply checks the Docker daemon API version and only
specifies platform specification when the daemon API version is 1.41 or
greater.
Fixes Issue #586
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.