[PR #33] Follow CNAMEs when checking CAA records #30

New issue

Open

opened 2026-03-13 16:27:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:27:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns-client/pull/33
Author: @marbens-arch
Created: 8/25/2025
Status: 🔄 Open

Base: master ← Head: caa-follow-cnames

📝 Commits (2)

7a9f23e Follow CNAMEs when checking CAA records
e853f6d Fix duplicate CAA queries when a CNAME pointing to itself is returned

📊 Changes

1 file changed (+22 additions, -6 deletions)

View changed files

📝 pkg/dnsclient/caarecord.go (+22 -6)

📄 Description

Without this change, when checking CAA records, CNAMEs would be considered "unexpected", and there would be an error.

With this change, CNAMEs will be considered "expected", and will be followed if the nameserver doesn't support recursion.

Depends on #30.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns-client/pull/33 **Author:** [@marbens-arch](https://github.com/marbens-arch) **Created:** 8/25/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `caa-follow-cnames` --- ### 📝 Commits (2) - [`7a9f23e`](https://github.com/acme-dns/acme-dns-client/commit/7a9f23e669a33b6f3a625e9feae69e0ac36027ce) Follow CNAMEs when checking CAA records - [`e853f6d`](https://github.com/acme-dns/acme-dns-client/commit/e853f6db031ad3207e127400496772b757c48490) Fix duplicate CAA queries when a CNAME pointing to itself is returned ### 📊 Changes **1 file changed** (+22 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/dnsclient/caarecord.go` (+22 -6) </details> ### 📄 Description Without this change, when checking CAA records, CNAMEs would be considered "unexpected", and there would be an error. With this change, CNAMEs will be considered "expected", and will be followed if the nameserver doesn't support recursion. Depends on #30. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>