mirror of
https://github.com/YouG-o/YouTube-No-Translation.git
synced 2026-04-26 02:25:53 +03:00
[GH-ISSUE #45] Issue: Sidebar videos seem to be unaffected by this addon and still remain translated #40
Labels
No labels
ToDo
bug
enhancement
enhancement
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/YouTube-No-Translation#40
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TteokbokkiNari on GitHub (Jun 22, 2025).
Original GitHub issue: https://github.com/YouG-o/YouTube-No-Translation/issues/45
Originally assigned to: @YouG-o on GitHub.
Description
Seems some video titles in the side bar aren't un-translated and still appear in Korean, even though I know those channels are for a western audience with an English title.
Steps to Reproduce (if you noticed a specific pattern)
Environment
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:141.0) Gecko/20100101 Firefox/141.0
Example Video (Required)
N/A as it only happens on the side bar or search page. Actual videos themselves do get un-translated on the video page itself or on the main search page.
Screenshots (Optional)
Additional Context (Optional)
When scrolling on the main search page I do see the addon working, as Korean titles get turned into English titles, as well as on the video pages themselves where it just appears English, but it seems the side-bar remains unaffected by this addon.
I toggled on every beta feature as well in case it might solve the issue, but it doesn't seem to help.
I also have the addons installed:
@YouG-o commented on GitHub (Jun 22, 2025):
Not sure I get it. It happens only on sidebar (by sidebar you mean the recommended videos on the right when you're watching a video am I correct?) or also on search page?
@TteokbokkiNari commented on GitHub (Jun 22, 2025):
Yes, correct, sorry. ^^
See Louis Rossmann's title:
Video page itself:
I scrolled again, though this time it seems it did actually work partially as I had to scroll decently far to see any Korean title on an English channel, but seems it eventually happened again.
Maybe there's some API limit or something I am triggering?
@YouG-o commented on GitHub (Jun 22, 2025):
Ok, thanks. That's unlikely to be an API limitation — I'm betting it's just my observers not being efficient enough.
As for your other extensions, the only one that might cause conflicts is DeArrow, I think, since it edits titles (I believe? Never used it myself — just know it through its reputation). Just disable it really quick just to try and let me know if it changes anything.
Anyway, I'll have a look soon.
@YouG-o commented on GitHub (Jun 22, 2025):
You can also check your browser console for logs, I made an easy to follow logggin system, just filter with "titles" and you'll see if there's error, or if the concerned videos where never replaced at all.
Also, when a title is still translated, just switch to an other tab and come back, it triggers a manual video check and titles replacement if needed. If it fix the titles, it means my observers really need an update :D if it doesn't change anything then it's something else.
@TteokbokkiNari commented on GitHub (Jun 22, 2025):
Disabled DeArrow and it's still happening unfortunately. >_<;
@TteokbokkiNari commented on GitHub (Jun 22, 2025):
So I have the console running and oddly when these video appeared while scrolling nothing in the console popped up. D:
The thing is I see some titles go from Korean > English while scrolling but some do seem to stay Korean, like these two.
Keep scrolling but my console doesn't seem to update. 😭
@TteokbokkiNari commented on GitHub (Jun 22, 2025):
And trying to switch tabs doesn't seem to affect the affected titles, unless I am doing something wrong.
@YouG-o commented on GitHub (Jun 22, 2025):
Ok thanks for those infos. I'll have a look later today.
@YouG-o commented on GitHub (Jun 22, 2025):
One last thing please : In the loggings you provided I see some Korean titles replaced by what seems to be the same exact title.
The thing is : I have a function checking if titles are the same before replacing it (so it only updates translated titles) so it should not happen.
Can you confirm that thoses titles are the same? My comparing function probably does not support Korean characters if that's the case. Need to update it.
Thanks and sorry for all those requests :)
EDIT : Nevermind. It's probably due to DeArrow updating titles to, I see it also happens on your English titles. (so DeArrow may cause issues, but not the one from your request)
@YouG-o commented on GitHub (Jun 22, 2025):
I did some tests and I think I found the issue.
If you scroll, it loads new titles and they are still translated right (for the sidebar)? Scroll again until it load new videos, then scroll up, the videos that were still translated should now be ok. (check if that's the case and confirm it to me please)
It's a timing issue, when the observer detect mutation on the sidebar, it instantly calls the title replacement, but the videos are not yet loaded.
I just need to fix that timing. I will do this later today and publish an update on Mozilla and Chrome stores.
@YouG-o commented on GitHub (Jun 22, 2025):
v2.4.24 SHOULD fix your issue. Already available on Mozilla, waiting for approval on Chrome.
Added a temporary fix for the timing I mentioned earlier.
Also, I noticed that side bar's html structure is a bit different when you are logged in to your account than when you're not logged in, this was causing the fact that nothing happened when you were scrolling. I did not notice this one before because I do my tests on a clean browser (so logged off), and in my personnal usage, I don't have that many translated videos in my recommendations. Anyway, I fixed it too.
Don't hesitate to open a new issue if you still have this problem, or any new one.
@TteokbokkiNari commented on GitHub (Jun 22, 2025):
Thanks! I'll give it a go and report back if it still is broken! ^^