starred/WiFiManager

Fork 0

mirror of https://github.com/tzapu/WiFiManager.git synced 2026-04-27 09:05:56 +03:00

[GH-ISSUE #409] Convert all form processing to POST #344

New issue

Open

opened 2026-02-28 01:24:52 +03:00 by kerem · 6 comments

kerem commented

2026-02-28 01:24:52 +03:00

Owner

Originally created by @tablatronix on GitHub (Aug 30, 2017).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/409

Get is not a secure method of submitting forms on an open ap specifically.

convert all to post

❓ leave url forms as get? but what if inputs get added later etc, not sure how to handle, all post for now.

support GET optionally ( for script based url programming )
the library seems to not care, however we can deny by checking
server->method() == HTTP_GET

Originally created by @tablatronix on GitHub (Aug 30, 2017). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/409 Get is not a secure method of submitting forms on an open ap specifically. - [x] convert all to post ❓ leave url forms as get? but what if inputs get added later etc, not sure how to handle, all post for now. support GET optionally ( for script based url programming ) the library seems to not care, however we can deny by checking `server->method() == HTTP_GET`

kerem added the

enhancement

Question

labels

2026-02-28 01:24:52 +03:00

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tzapu commented on GitHub (Aug 30, 2017):

why not form submissions POST and whatever's not a form submision GET?
if you are using a browser and not the captive portal using the back button becomes a pain in the ass if you navigate between POSTs

@tzapu commented on GitHub (Aug 30, 2017): why not form submissions POST and whatever's not a form submision GET? if you are using a browser and not the captive portal using the back button becomes a pain in the ass if you navigate between POSTs

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tzapu commented on GitHub (Aug 30, 2017):

the change shouldn't be big either, i guess just changing the form to POST and making sure it gets the params from the POST rather than string, not sure if that part is not transparent anyway

@tzapu commented on GitHub (Aug 30, 2017): the change shouldn't be big either, i guess just changing the form to POST and making sure it gets the params from the POST rather than string, not sure if that part is not transparent anyway

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tzapu commented on GitHub (Aug 30, 2017):

like you ve actually done in your last commit :P
i'll but out, you are a machine :D

@tzapu commented on GitHub (Aug 30, 2017): like you ve actually done in your last commit :P i'll but out, you are a machine :D

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tablatronix commented on GitHub (Aug 30, 2017):

I tested and changed all to post, I think it better than to have to decide which page will have a form on it etc. we can adjust as needed, if it is a problem with browser history.

@tablatronix commented on GitHub (Aug 30, 2017): I tested and changed all to post, I think it better than to have to decide which page will have a form on it etc. we can adjust as needed, if it is a problem with browser history.

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tablatronix commented on GitHub (Aug 30, 2017):

test all devices with POST on all forms provide feedback on browser back and refresh capability.

So far browser history works as expected

@tablatronix commented on GitHub (Aug 30, 2017): - [ ] test all devices with POST on all forms provide feedback on browser back and refresh capability. So far browser history works as expected

kerem commented

2026-02-28 01:24:52 +03:00

Author

Owner

@tablatronix commented on GitHub (Aug 30, 2017):

why not replace form buttons with actual proper links ?

hmm I am now wondering if semantically these should be styled links with hrefs, and only actual forms be forms with inputs... #410

@tablatronix commented on GitHub (Aug 30, 2017): why not replace form buttons with actual proper links ? hmm I am now wondering if semantically these should be styled links with hrefs, and only actual forms be forms with inputs... #410