mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 17:15:53 +03:00
[PR #1777] [MERGED] Enhance cache strategy with board-specific cache keys #1830
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1830
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/tzapu/WiFiManager/pull/1777
Author: @anilrajrimal1
Created: 11/8/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @tablatronix
Base:
master← Head:feat/cache-keys-per-board📝 Commits (2)
ad651aefix(compile_example.yaml): Fix cache key inconsistency and correct typo in 'Compile examples' workflow5874ab5feat(compile_library.yml): Use board-specific cache keys to avoid conflicts📊 Changes
2 files changed (+29 additions, -11 deletions)
View changed files
📝
.github/workflows/compile_examples.yaml(+21 -8)📝
.github/workflows/compile_library.yml(+8 -3)📄 Description
Summary:
This PR refines the caching strategy used in the
Compile LibraryGitHub Actions workflow by making cache keys board-specific. Previously, caches forpipandPlatformIOwere shared across all board configurations, which could lead to cache conflicts or inefficiencies. Now, each board (e.g.,nodemcuv2,lolin32) has its own unique cache, improving cache hits and reducing build times.Changes:
pipandPlatformIOto incorporate the board matrix value.Motivation:
This change improves the efficiency of the CI/CD pipeline by ensuring that the cache is appropriately scoped for each board, optimizing build times for different configurations.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.