[PR #1555] [CLOSED] Only reconnect if WiFi updated #1777

Closed
opened 2026-02-28 02:12:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1555
Author: @presslab-us
Created: 1/27/2023
Status: Closed

Base: masterHead: no_connect_save_params


📝 Commits (1)

  • 9bc4bc5 Only reconnect if WiFi updated

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 WiFiManager.cpp (+1 -2)

📄 Description

If only the parameters have been updated then don't try to reconnect on save. Otherwise _ssid and _pass are blank (because "placeholder" input attribute is used) and the connection will fail.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1555 **Author:** [@presslab-us](https://github.com/presslab-us) **Created:** 1/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `no_connect_save_params` --- ### 📝 Commits (1) - [`9bc4bc5`](https://github.com/tzapu/WiFiManager/commit/9bc4bc57fc79c145b74b4f4714d8dc4fa2704359) Only reconnect if WiFi updated ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+1 -2) </details> ### 📄 Description If only the parameters have been updated then don't try to reconnect on save. Otherwise `_ssid` and `_pass` are blank (because "placeholder" input attribute is used) and the connection will fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 02:12:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1777
No description provided.