[PR #487] [MERGED] make WIFI_MANAGER_MAX_PARAMS customizable #1630

New issue

Closed

opened 2026-02-28 01:30:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/487
Author: @mtiutiu
Created: 1/22/2018
Status: ✅ Merged
Merged: 2/1/2018
Merged by: @tablatronix

Base: master ← Head: master

📝 Commits (1)

8c906af make WIFI_MANAGER_MAX_PARAMS customizable

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 WiFiManager.h (+2 -0)

📄 Description

I think it's pretty useful to have this parameter customizable so that users can change it from outside if required (e.g platformio, make, etc).

For example when using platformio I can set this in platformio.ini:
build_flags = -DWIFI_MANAGER_MAX_PARAMS=20

This allows me to change the value at compile time without modifying the library source code. I also provided the default value for it when not defined outside or somewhere else - you can see that in the code changes that I want to propose.

This approach can be used for other defines in this library source code if desired/required.

Very nice work btw regarding this library - very useful. Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/487 **Author:** [@mtiutiu](https://github.com/mtiutiu) **Created:** 1/22/2018 **Status:** ✅ Merged **Merged:** 2/1/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`8c906af`](https://github.com/tzapu/WiFiManager/commit/8c906af56303f3125ac3b69b54059e87f1203ae1) make WIFI_MANAGER_MAX_PARAMS customizable ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.h` (+2 -0) </details> ### 📄 Description I think it's pretty useful to have this parameter customizable so that users can change it from outside if required (e.g platformio, make, etc). For example when using platformio I can set this in platformio.ini: **build_flags = -DWIFI_MANAGER_MAX_PARAMS=20** This allows me to change the value at compile time without modifying the library source code. I also provided the default value for it when not defined outside or somewhere else - you can see that in the code changes that I want to propose. This approach can be used for other defines in this library source code if desired/required. Very nice work btw regarding this library - very useful. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>