[GH-ISSUE #1610] Root menu always empty #1373

New issue

Closed

opened 2026-02-28 01:29:48 +03:00 by kerem · 3 comments

kerem commented

2026-02-28 01:29:48 +03:00

Owner

Originally created by @nonsintetic on GitHub (May 18, 2023).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1610

Basic Infos

Hardware

WiFimanager Branch/Release: Master

Esp8266/Esp32:

Hardware: ESP32

Description

In the current Master branch the menu in the root page is always empty. Think I figured out why:

The comparison done in WiFiManager::setMenu() (to determine what menus should be displayed) always equals false now. Think this is because it's comparing pointers, memory addresses, instead of contents like before.

See comment in code below:

void WiFiManager::setMenu(const char * menu[], uint8_t size){
  _menuIds.clear();
  for(size_t i = 0; i < size; i++){
    for(size_t j = 0; j < _nummenutokens; j++){
      
    //following line is always false, the menu never gets populated
      if(menu[i] == _menutokens[j]){
        if((String)menu[i] == "param") _paramsInWifi = false; // param auto flag
        _menuIds.push_back(j);
      }

    }
  }
}

Originally created by @nonsintetic on GitHub (May 18, 2023). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1610 ### Basic Infos #### Hardware WiFimanager Branch/Release: Master Esp8266/Esp32: Hardware: ESP32 ### Description In the current Master branch the menu in the root page is always empty. Think I figured out why: The comparison done in `WiFiManager::setMenu()` (to determine what menus should be displayed) always equals false now. Think this is because it's comparing pointers, memory addresses, instead of contents like before. See comment in code below: ``` void WiFiManager::setMenu(const char * menu[], uint8_t size){ _menuIds.clear(); for(size_t i = 0; i < size; i++){ for(size_t j = 0; j < _nummenutokens; j++){ //following line is always false, the menu never gets populated if(menu[i] == _menutokens[j]){ if((String)menu[i] == "param") _paramsInWifi = false; // param auto flag _menuIds.push_back(j); } } } } ```

kerem closed this issue

2026-02-28 01:29:49 +03:00

kerem commented

2026-02-28 01:29:49 +03:00

Author

Owner

@tablatronix commented on GitHub (May 19, 2023):

Yeah looks like I changed the consts def but not the methods that use it crap

@tablatronix commented on GitHub (May 19, 2023): Yeah looks like I changed the consts def but not the methods that use it crap

kerem commented

2026-02-28 01:29:49 +03:00

Author

Owner

@tablatronix commented on GitHub (May 19, 2023):

Also need to check that nummenutokens size is set.

I clearly did not test this somehow

@tablatronix commented on GitHub (May 19, 2023): Also need to check that nummenutokens size is set. I clearly did not test this somehow

kerem commented

2026-02-28 01:29:49 +03:00

Author

Owner

@tablatronix commented on GitHub (May 19, 2023):

9b8de0d

@tablatronix commented on GitHub (May 19, 2023): 9b8de0d