[PR #365] [MERGED] Allow showing static IP config without predefined value #1610

New issue

Closed

opened 2026-02-28 01:30:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/365
Author: @vyruz1986
Created: 5/4/2017
Status: ✅ Merged
Merged: 9/8/2017
Merged by: @tablatronix

Base: development ← Head: master

📝 Commits (3)

486ea7d Allow showing static IP config without predefined value
136c0c9 Also show static IP fields when static IP is passed
0fc051a Merge remote-tracking branch 'refs/remotes/tzapu/master'

📊 Changes

2 files changed (+13 additions, -10 deletions)

View changed files

📝 WiFiManager.cpp (+9 -7)
📝 WiFiManager.h (+4 -3)

📄 Description

Previously a valid predefined static IP had to be passed before the
config page would show the IP, gateway and subnet fields. This did not
allow the config page to show 'optional' static IP fields.
Now a boolean can be passed to the autoConnect() function which will
specify whether the static IP fields should be shown or not.
When this boolean is true but no predefined values are passed and fields
are left blank in config page, wifiManager will revert to DHCP. This
allows user to choose between static IP or DHCP without changing code

For backwards compatibility we will show the static IP fields regardless of how the boolean is set.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/365 **Author:** [@vyruz1986](https://github.com/vyruz1986) **Created:** 5/4/2017 **Status:** ✅ Merged **Merged:** 9/8/2017 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `development` ← **Head:** `master` --- ### 📝 Commits (3) - [`486ea7d`](https://github.com/tzapu/WiFiManager/commit/486ea7db2c769df83527619dc1356740fbb84b30) Allow showing static IP config without predefined value - [`136c0c9`](https://github.com/tzapu/WiFiManager/commit/136c0c9cba70117237e822d7669e1244b401fc3f) Also show static IP fields when static IP is passed - [`0fc051a`](https://github.com/tzapu/WiFiManager/commit/0fc051a445d84a4c95d454f9be4333387b96a98a) Merge remote-tracking branch 'refs/remotes/tzapu/master' ### 📊 Changes **2 files changed** (+13 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+9 -7) 📝 `WiFiManager.h` (+4 -3) </details> ### 📄 Description Previously a valid predefined static IP had to be passed before the config page would show the IP, gateway and subnet fields. This did not allow the config page to show 'optional' static IP fields. Now a boolean can be passed to the autoConnect() function which will specify whether the static IP fields should be shown or not. When this boolean is true but no predefined values are passed and fields are left blank in config page, wifiManager will revert to DHCP. This allows user to choose between static IP or DHCP without changing code For backwards compatibility we will show the static IP fields regardless of how the boolean is set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>