[PR #48] [MERGED] Fix of temporary file handling and missing dll's in tests. #98

New issue

Closed

opened 2026-02-25 21:30:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/48
Author: @alphaleonis
Created: 8/29/2018
Status: ✅ Merged
Merged: 8/29/2018
Merged by: @brutaldev

Base: master ← Head: bug/47

📝 Commits (3)

e93fc8b Added .editorconfig to keep formatting of files.
c5a1b47 Added a few new tests to test signing in-place, and to a new location with and without .pdb-files present.
47572f5 - Updated a couple of test assemblies with PDB-files.

📊 Changes

13 files changed (+420 additions, -150 deletions)

View changed files

📝 .gitignore (+3 -0)
➕ src/.editorconfig (+14 -0)
📝 src/Brutal.Dev.StrongNameSigner.Tests/Brutal.Dev.StrongNameSigner.Tests.csproj (+13 -7)
📝 src/Brutal.Dev.StrongNameSigner.Tests/SignAssemblyTests.cs (+94 -1)
📝 src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.A.dll (+0 -0)
➕ src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.A.pdb (+0 -0)
📝 src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.B.dll (+0 -0)
➕ src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.B.pdb (+0 -0)
📝 src/Brutal.Dev.StrongNameSigner.sln (+1 -0)
📝 src/Brutal.Dev.StrongNameSigner/Brutal.Dev.StrongNameSigner.csproj (+1 -0)
➕ src/Brutal.Dev.StrongNameSigner/ForceAssemblyReferenceAttribute.cs (+21 -0)
📝 src/Brutal.Dev.StrongNameSigner/Properties/AssemblyInfo.cs (+11 -1)
📝 src/Brutal.Dev.StrongNameSigner/SigningHelper.cs (+262 -141)

📄 Description

In reference to #47

Updated a couple of test assemblies with PDB-files and added a couple of tests to verify some previously failing scenarios.
Added strong references to the Mono.Cecil.Pdb, Mdb and Rocks libraries so that they are among other things properly copied to the test project. (See AssemblyInfo.cs). If the Mono.Cecil.Pdb.dll is not copied locally (which it wasn't), then the symbol reading doesn't work.
Fixed temporary file handling in SigningHelper, so that it now uses a temporary directory to store the generated files during generation and ensures they are deleted afterwards. I refactored out the file handling into its own private class OutputFileManager which takes care of creating the temporary directory etc. Cleans up the methods using it considerably and avoids repetitive code.
Also added an .editorconfig so that the indentation remained consistent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/48 **Author:** [@alphaleonis](https://github.com/alphaleonis) **Created:** 8/29/2018 **Status:** ✅ Merged **Merged:** 8/29/2018 **Merged by:** [@brutaldev](https://github.com/brutaldev) **Base:** `master` ← **Head:** `bug/47` --- ### 📝 Commits (3) - [`e93fc8b`](https://github.com/brutaldev/StrongNameSigner/commit/e93fc8b3ec603c4dcf469e90370b8dd4251dae3f) Added .editorconfig to keep formatting of files. - [`c5a1b47`](https://github.com/brutaldev/StrongNameSigner/commit/c5a1b47d557493ebeda6721fb159129d0fd25fd0) Added a few new tests to test signing in-place, and to a new location with and without .pdb-files present. - [`47572f5`](https://github.com/brutaldev/StrongNameSigner/commit/47572f52d37f2e64d7664e120a66e3102e3b3c9d) - Updated a couple of test assemblies with PDB-files. ### 📊 Changes **13 files changed** (+420 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) ➕ `src/.editorconfig` (+14 -0) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/Brutal.Dev.StrongNameSigner.Tests.csproj` (+13 -7) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/SignAssemblyTests.cs` (+94 -1) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.A.dll` (+0 -0) ➕ `src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.A.pdb` (+0 -0) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.B.dll` (+0 -0) ➕ `src/Brutal.Dev.StrongNameSigner.Tests/TestAssemblies/Brutal.Dev.StrongNameSigner.TestAssembly.B.pdb` (+0 -0) 📝 `src/Brutal.Dev.StrongNameSigner.sln` (+1 -0) 📝 `src/Brutal.Dev.StrongNameSigner/Brutal.Dev.StrongNameSigner.csproj` (+1 -0) ➕ `src/Brutal.Dev.StrongNameSigner/ForceAssemblyReferenceAttribute.cs` (+21 -0) 📝 `src/Brutal.Dev.StrongNameSigner/Properties/AssemblyInfo.cs` (+11 -1) 📝 `src/Brutal.Dev.StrongNameSigner/SigningHelper.cs` (+262 -141) </details> ### 📄 Description In reference to #47 - Updated a couple of test assemblies with PDB-files and added a couple of tests to verify some previously failing scenarios. - Added strong references to the Mono.Cecil.Pdb, Mdb and Rocks libraries so that they are among other things properly copied to the test project. (See `AssemblyInfo.cs`). If the Mono.Cecil.Pdb.dll is not copied locally (which it wasn't), then the symbol reading doesn't work. - Fixed temporary file handling in SigningHelper, so that it now uses a temporary directory to store the generated files during generation and ensures they are deleted afterwards. I refactored out the file handling into its own private class `OutputFileManager` which takes care of creating the temporary directory etc. Cleans up the methods using it considerably and avoids repetitive code. - Also added an .editorconfig so that the indentation remained consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>