[PR #98] [MERGED] Fix temp directory access when signing in parallel #106

New issue

Closed

opened 2026-02-25 21:30:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/98
Author: @OliverW10
Created: 10/4/2023
Status: ✅ Merged
Merged: 10/4/2023
Merged by: @brutaldev

Base: master ← Head: fix-temp-directory-name

📝 Commits (3)

aef9e93 add parallel test
573553b append guid to temp directory
4972b1c remove unnesisary usings

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 src/Brutal.Dev.StrongNameSigner.Tests/SignAssemblyTests.cs (+10 -0)
📝 src/Brutal.Dev.StrongNameSigner/SigningHelper.cs (+1 -1)

📄 Description

If multiple signings are running at the same time, all of them would use the same temp directory name and when one finishes it deletes the temp directory along with the files the other instances may have still wanted to use.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/98 **Author:** [@OliverW10](https://github.com/OliverW10) **Created:** 10/4/2023 **Status:** ✅ Merged **Merged:** 10/4/2023 **Merged by:** [@brutaldev](https://github.com/brutaldev) **Base:** `master` ← **Head:** `fix-temp-directory-name` --- ### 📝 Commits (3) - [`aef9e93`](https://github.com/brutaldev/StrongNameSigner/commit/aef9e93e4984bd085eb7215199008aa21758d978) add parallel test - [`573553b`](https://github.com/brutaldev/StrongNameSigner/commit/573553b0e99d53d58f0bfba3e16446a507c5fd06) append guid to temp directory - [`4972b1c`](https://github.com/brutaldev/StrongNameSigner/commit/4972b1ce0501d4bfad867bba65d0eb89b51d9dcc) remove unnesisary usings ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Brutal.Dev.StrongNameSigner.Tests/SignAssemblyTests.cs` (+10 -0) 📝 `src/Brutal.Dev.StrongNameSigner/SigningHelper.cs` (+1 -1) </details> ### 📄 Description If multiple signings are running at the same time, all of them would use the same temp directory name and when one finishes it [deletes the temp directory](https://github.com/brutaldev/StrongNameSigner/blob/master/src/Brutal.Dev.StrongNameSigner/SigningHelper.cs#L515) along with the files the other instances may have still wanted to use. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>