mirror of
https://github.com/heysem-useinsider/Stringz.git
synced 2026-04-26 07:15:52 +03:00
[PR #41] [CLOSED] Feature: Use recommended SF symbols #42
Labels
No labels
bug
bug
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Stringz#42
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/heysem-useinsider/Stringz/pull/41
Author: @MauriceArikoglu
Created: 4/13/2023
Status: ❌ Closed
Base:
main← Head:feature/sf-symbols📝 Commits (3)
ef05992Use SFSymbols052b97aUse recommended project settings06add72Update project.pbxproj📊 Changes
63 files changed (+138 additions, -470 deletions)
View changed files
📝
Stringz.xcodeproj/project.pbxproj(+7 -3)📝
Stringz/AppUserDefaults.swift(+13 -1)➖
Stringz/Assets.xcassets/action.add.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.add.imageset/plus.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.add.small.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.add.small.imageset/plus.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.addLanguage.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.addLanguage.imageset/globe.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.delete.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.delete.imageset/delete.right.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.filter.all.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.filter.all.imageset/infinity.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.filter.translated.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.filter.translated.imageset/checkmark.circle.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.filter.untranslated.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.filter.untranslated.imageset/exclamationmark.triangle.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.load.small.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.load.small.imageset/square.and.arrow.down.pdf(+0 -0)➖
Stringz/Assets.xcassets/action.localize.small.imageset/Contents.json(+0 -15)➖
Stringz/Assets.xcassets/action.localize.small.imageset/wand.and.stars.pdf(+0 -0)...and 43 more files
📄 Description
Instead of bundling images it is recommended to use the equivalent SF symbols.
Some images were not appropriate for the case they were used in, so I replaced them with the appropriate alternative.
I also fixed a problem with the Symbols being cut as well as improperly scaled in some cases.
SF Symbols is available from macOS 11 onwards, so I changed the build target from 10.15 to 11, updated the project settings to the recommended settings and replaced a deprecated function call to NSWorkspace. Due to the optional nature of the presence of Xcode on a users host while Xcode is required to run I implemented a runtime check warning the user if Xcode is not found.
Hint: This is based on #40 - can be merged independently though
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.