mirror of
https://github.com/heysem-useinsider/Stringz.git
synced 2026-04-26 07:15:52 +03:00
[PR #40] [CLOSED] Bugfix: Updater crash #41
Labels
No labels
bug
bug
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Stringz#41
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/heysem-useinsider/Stringz/pull/40
Author: @MauriceArikoglu
Created: 4/13/2023
Status: ❌ Closed
Base:
main← Head:bugfix/updater-crash📝 Commits (3)
527e4efFixes a crash with the updater implementation0255023Connect IBOutlet in PreferenceController66d6d49Update project.pbxproj📊 Changes
6 files changed (+70 additions, -12 deletions)
View changed files
📝
Stringz.xcodeproj/project.pbxproj(+4 -0)📝
Stringz/AppDelegate.swift(+3 -4)📝
Stringz/Common.swift(+1 -0)📝
Stringz/GeneralPreference.xib(+2 -0)📝
Stringz/GeneralPreferenceViewController.swift(+22 -8)➕
Stringz/UpdaterController.swift(+38 -0)📄 Description
The Updater implementation was not working, as the SPUStandardUpdaterController was never initialized, this led to an unexpected nil crash (force unwrap).
Also the interface did not reflect the user preference state as no IBOutlets were connected, this is also fixed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.