[PR #40] [CLOSED] Bugfix: Updater crash #41

Closed
opened 2026-03-02 05:16:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/heysem-useinsider/Stringz/pull/40
Author: @MauriceArikoglu
Created: 4/13/2023
Status: Closed

Base: mainHead: bugfix/updater-crash


📝 Commits (3)

  • 527e4ef Fixes a crash with the updater implementation
  • 0255023 Connect IBOutlet in PreferenceController
  • 66d6d49 Update project.pbxproj

📊 Changes

6 files changed (+70 additions, -12 deletions)

View changed files

📝 Stringz.xcodeproj/project.pbxproj (+4 -0)
📝 Stringz/AppDelegate.swift (+3 -4)
📝 Stringz/Common.swift (+1 -0)
📝 Stringz/GeneralPreference.xib (+2 -0)
📝 Stringz/GeneralPreferenceViewController.swift (+22 -8)
Stringz/UpdaterController.swift (+38 -0)

📄 Description

The Updater implementation was not working, as the SPUStandardUpdaterController was never initialized, this led to an unexpected nil crash (force unwrap).
Also the interface did not reflect the user preference state as no IBOutlets were connected, this is also fixed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/heysem-useinsider/Stringz/pull/40 **Author:** [@MauriceArikoglu](https://github.com/MauriceArikoglu) **Created:** 4/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bugfix/updater-crash` --- ### 📝 Commits (3) - [`527e4ef`](https://github.com/heysem-useinsider/Stringz/commit/527e4ef053b7a788751efe32529ae0efacf3708f) Fixes a crash with the updater implementation - [`0255023`](https://github.com/heysem-useinsider/Stringz/commit/02550232f30e556b3b33c79a49b19cb42db2117a) Connect IBOutlet in PreferenceController - [`66d6d49`](https://github.com/heysem-useinsider/Stringz/commit/66d6d49f3780ac3853beaa32194b92f040be7d9c) Update project.pbxproj ### 📊 Changes **6 files changed** (+70 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Stringz.xcodeproj/project.pbxproj` (+4 -0) 📝 `Stringz/AppDelegate.swift` (+3 -4) 📝 `Stringz/Common.swift` (+1 -0) 📝 `Stringz/GeneralPreference.xib` (+2 -0) 📝 `Stringz/GeneralPreferenceViewController.swift` (+22 -8) ➕ `Stringz/UpdaterController.swift` (+38 -0) </details> ### 📄 Description The Updater implementation was not working, as the SPUStandardUpdaterController was never initialized, this led to an unexpected nil crash (force unwrap). Also the interface did not reflect the user preference state as no IBOutlets were connected, this is also fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 05:16:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Stringz#41
No description provided.