[PR #314] [MERGED] 19 setup linting andor autoformatting for backend #380

New issue

Closed

opened 2026-02-27 19:17:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/314
Author: @EddieTheCubeHead
Created: 5/13/2024
Status: ✅ Merged
Merged: 5/13/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 19-setup-linting-andor-autoformatting-for-backend

📝 Commits (10+)

ed57e3d #19 Install ruff and run ruff fix for the first time
5c41c0a #19 implement all wanted rules and run autofix
0b7bc1b #19 Run ruff format
f956277 #19 Disable annotations for self and cls, re-enable trailing commas
adde7bf #19 ignore pytest lint in non-test folders, ignore require init.py in alembic folder
251bbd8 #19 More trailing comma fixes
8da36c9 #19 even more trailing comma fixes
3280a15 #19 fix linter errors in resource search features
0824e96 #19 pytest options into pythonproject.toml
8bc3ebe #19 fix issues found in linting for rest of pool features

📊 Changes

69 files changed (+3232 additions, -2284 deletions)

View changed files

📝 .github/workflows/backend-ci.yml (+10 -0)
📝 server/alembic.ini (+5 -5)
➕ server/pyproject.toml (+100 -0)
➖ server/pytest.ini (+0 -7)
📝 server/src/alembic/env.py (+6 -18)
📝 server/src/alembic/versions/149e2197ecff_add_data_required_for_login_and_auth_.py (+11 -11)
📝 server/src/alembic/versions/25c34e5bf930_data_changes_required_for_pool_.py (+18 -18)
📝 server/src/alembic/versions/27048d682757_make_user_icon_url_nullable.py (+6 -10)
📝 server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py (+31 -21)
📝 server/src/alembic/versions/4fc5f9bc5558_double_avatar_url_length.py (+18 -12)
📝 server/src/alembic/versions/62ec829ee3f3_caching_current_song_playback_data_in_.py (+12 -12)
📝 server/src/alembic/versions/6b917dddd71e_add_model_for_pool_members.py (+18 -18)
📝 server/src/alembic/versions/70e02357c5ff_big_changes_for_support_for_pool_.py (+50 -44)
📝 server/src/alembic/versions/7851701cd257_add_playback_status_entity.py (+17 -16)
📝 server/src/alembic/versions/a864a5084871_new_field_for_user_session_for_storing_.py (+6 -6)
📝 server/src/alembic/versions/aeb0c7f142d6_increase_field_sizes_for_pool_members.py (+38 -28)
📝 server/src/alembic/versions/af9978211950_add_user_table.py (+10 -10)
📝 server/src/api/application.py (+12 -13)
📝 server/src/api/auth/dependencies.py (+31 -34)
📝 server/src/api/auth/routes.py (+2 -6)

...and 49 more files

📄 Description

Added ruff with a lot of rules

Autoformatted everything

Fixed linting errors

Added ruff into cicd

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/314 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 5/13/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `19-setup-linting-andor-autoformatting-for-backend` --- ### 📝 Commits (10+) - [`ed57e3d`](https://github.com/EddieTheCubeHead/Stagnum/commit/ed57e3d9907777b2c2f3c6609361a5c1768df194) #19 Install ruff and run ruff fix for the first time - [`5c41c0a`](https://github.com/EddieTheCubeHead/Stagnum/commit/5c41c0a7db2e5d849c0b71567d0dc853f9226f25) #19 implement all wanted rules and run autofix - [`0b7bc1b`](https://github.com/EddieTheCubeHead/Stagnum/commit/0b7bc1b2b5b504c5f6419f959b6f69b6bb68dd10) #19 Run ruff format - [`f956277`](https://github.com/EddieTheCubeHead/Stagnum/commit/f956277caa8fae90d6638af59c533c3898c518c1) #19 Disable annotations for self and cls, re-enable trailing commas - [`adde7bf`](https://github.com/EddieTheCubeHead/Stagnum/commit/adde7bf7df17144b326454a55a2f26920670c2da) #19 ignore pytest lint in non-test folders, ignore require __init__.py in alembic folder - [`251bbd8`](https://github.com/EddieTheCubeHead/Stagnum/commit/251bbd866da4c9add8ad3bd419c6cebee0732e18) #19 More trailing comma fixes - [`8da36c9`](https://github.com/EddieTheCubeHead/Stagnum/commit/8da36c9588065c0b9f669d3e88524db5c7b8a1a4) #19 even more trailing comma fixes - [`3280a15`](https://github.com/EddieTheCubeHead/Stagnum/commit/3280a153cb99cee3f69dfb359bc9e70c5c862160) #19 fix linter errors in resource search features - [`0824e96`](https://github.com/EddieTheCubeHead/Stagnum/commit/0824e96bcfca631533cde1676b1f4f83d5434824) #19 pytest options into pythonproject.toml - [`8bc3ebe`](https://github.com/EddieTheCubeHead/Stagnum/commit/8bc3ebe926b5a2c5ea349c59e21f6dacb7762fd2) #19 fix issues found in linting for rest of pool features ### 📊 Changes **69 files changed** (+3232 additions, -2284 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/backend-ci.yml` (+10 -0) 📝 `server/alembic.ini` (+5 -5) ➕ `server/pyproject.toml` (+100 -0) ➖ `server/pytest.ini` (+0 -7) 📝 `server/src/alembic/env.py` (+6 -18) 📝 `server/src/alembic/versions/149e2197ecff_add_data_required_for_login_and_auth_.py` (+11 -11) 📝 `server/src/alembic/versions/25c34e5bf930_data_changes_required_for_pool_.py` (+18 -18) 📝 `server/src/alembic/versions/27048d682757_make_user_icon_url_nullable.py` (+6 -10) 📝 `server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py` (+31 -21) 📝 `server/src/alembic/versions/4fc5f9bc5558_double_avatar_url_length.py` (+18 -12) 📝 `server/src/alembic/versions/62ec829ee3f3_caching_current_song_playback_data_in_.py` (+12 -12) 📝 `server/src/alembic/versions/6b917dddd71e_add_model_for_pool_members.py` (+18 -18) 📝 `server/src/alembic/versions/70e02357c5ff_big_changes_for_support_for_pool_.py` (+50 -44) 📝 `server/src/alembic/versions/7851701cd257_add_playback_status_entity.py` (+17 -16) 📝 `server/src/alembic/versions/a864a5084871_new_field_for_user_session_for_storing_.py` (+6 -6) 📝 `server/src/alembic/versions/aeb0c7f142d6_increase_field_sizes_for_pool_members.py` (+38 -28) 📝 `server/src/alembic/versions/af9978211950_add_user_table.py` (+10 -10) 📝 `server/src/api/application.py` (+12 -13) 📝 `server/src/api/auth/dependencies.py` (+31 -34) 📝 `server/src/api/auth/routes.py` (+2 -6) _...and 49 more files_ </details> ### 📄 Description Added ruff with a lot of rules Autoformatted everything Fixed linting errors Added ruff into cicd --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>