[PR #192] [MERGED] 178 refactor frontend codebase #314

New issue

Closed

opened 2026-02-27 19:17:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/192
Author: @OttoAhlfors
Created: 4/5/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @OttoAhlfors

Base: master ← Head: 178-refactor-frontend-codebase

📝 Commits (10+)

30a3bfb Deleted unnecesary comments
cbc0bc2 Removed console.logs and replaced with // TODO Error alert
5dae48e Removed unused page route
16d143b Removed unused code
9557873 Linting changes
0ad28a3 re arranged some files
bc677b3 Search component typing
0e6b467 More search component lint fixes
8b04828 Pool component lint fixes
a2d7e07 Deleted extra theme folder

📊 Changes

41 files changed (+536 additions, -879 deletions)

View changed files

📝 client/.eslintrc.json (+19 -6)
📝 client/app/about/page.tsx (+3 -9)
📝 client/app/layout.tsx (+7 -4)
📝 client/app/login/page.tsx (+6 -6)
📝 client/app/page.tsx (+23 -27)
➖ client/app/pool/page.tsx (+0 -135)
➖ client/app/utils/mockData.ts (+0 -45)
➖ client/app/utils/theme.ts (+0 -23)
📝 client/components/buttons/altButton.tsx (+7 -5)
📝 client/components/buttons/defaulButton.tsx (+11 -5)
📝 client/components/buttons/iconButtons/addToPoolButton.tsx (+11 -11)
📝 client/components/buttons/iconButtons/collapseIconButton.tsx (+11 -4)
📝 client/components/buttons/iconButtons/deleteButton.tsx (+31 -34)
📝 client/components/buttons/iconButtons/showMoreIconButton.tsx (+13 -13)
📝 client/components/buttons/negativeButton.tsx (+11 -5)
📝 client/components/buttons/skipButton.tsx (+14 -9)
➖ client/components/layout/albumCard.tsx (+0 -44)
📝 client/components/layout/footer.tsx (+8 -5)
➖ client/components/lists/PoolList.tsx (+0 -94)
➖ client/components/lists/PoolListItem.tsx (+0 -83)

...and 21 more files

📄 Description

File structure has been changes so please give your feedback on it

two linting warnings remain, one will be fixed along side with the footter and another
needs a bit more knowledge than I have at the current moment but I do not want it to stop the ticket if someone knows a fix you are welcome to fit it

just run "npm run lint" and its the non image one

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/192 **Author:** [@OttoAhlfors](https://github.com/OttoAhlfors) **Created:** 4/5/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@OttoAhlfors](https://github.com/OttoAhlfors) **Base:** `master` ← **Head:** `178-refactor-frontend-codebase` --- ### 📝 Commits (10+) - [`30a3bfb`](https://github.com/EddieTheCubeHead/Stagnum/commit/30a3bfb94be0df6ae08ee7a4cd94396e66b8c063) Deleted unnecesary comments - [`cbc0bc2`](https://github.com/EddieTheCubeHead/Stagnum/commit/cbc0bc2b09b38eec08e3afe3dcdd1d3d286f2b1e) Removed console.logs and replaced with // TODO Error alert - [`5dae48e`](https://github.com/EddieTheCubeHead/Stagnum/commit/5dae48ed5fe9e329ea93f0ac1b9343ba701beb05) Removed unused page route - [`16d143b`](https://github.com/EddieTheCubeHead/Stagnum/commit/16d143bf3b3bec5bc933d5d23c2527aac77ab854) Removed unused code - [`9557873`](https://github.com/EddieTheCubeHead/Stagnum/commit/955787395bf86471b507da1f032f7a346799d2d7) Linting changes - [`0ad28a3`](https://github.com/EddieTheCubeHead/Stagnum/commit/0ad28a33f14c617365ed1209fe2d749862fd27a1) re arranged some files - [`bc677b3`](https://github.com/EddieTheCubeHead/Stagnum/commit/bc677b3fbe49246bd9f8e4f0bcf169731b80d04c) Search component typing - [`0e6b467`](https://github.com/EddieTheCubeHead/Stagnum/commit/0e6b46763ac0aa1b9726978ec171873acc74c9d9) More search component lint fixes - [`8b04828`](https://github.com/EddieTheCubeHead/Stagnum/commit/8b04828c56dc7be14e2745825133478aba22cbfe) Pool component lint fixes - [`a2d7e07`](https://github.com/EddieTheCubeHead/Stagnum/commit/a2d7e0770b4ceb114ce81aff91873357bda057a8) Deleted extra theme folder ### 📊 Changes **41 files changed** (+536 additions, -879 deletions) <details> <summary>View changed files</summary> 📝 `client/.eslintrc.json` (+19 -6) 📝 `client/app/about/page.tsx` (+3 -9) 📝 `client/app/layout.tsx` (+7 -4) 📝 `client/app/login/page.tsx` (+6 -6) 📝 `client/app/page.tsx` (+23 -27) ➖ `client/app/pool/page.tsx` (+0 -135) ➖ `client/app/utils/mockData.ts` (+0 -45) ➖ `client/app/utils/theme.ts` (+0 -23) 📝 `client/components/buttons/altButton.tsx` (+7 -5) 📝 `client/components/buttons/defaulButton.tsx` (+11 -5) 📝 `client/components/buttons/iconButtons/addToPoolButton.tsx` (+11 -11) 📝 `client/components/buttons/iconButtons/collapseIconButton.tsx` (+11 -4) 📝 `client/components/buttons/iconButtons/deleteButton.tsx` (+31 -34) 📝 `client/components/buttons/iconButtons/showMoreIconButton.tsx` (+13 -13) 📝 `client/components/buttons/negativeButton.tsx` (+11 -5) 📝 `client/components/buttons/skipButton.tsx` (+14 -9) ➖ `client/components/layout/albumCard.tsx` (+0 -44) 📝 `client/components/layout/footer.tsx` (+8 -5) ➖ `client/components/lists/PoolList.tsx` (+0 -94) ➖ `client/components/lists/PoolListItem.tsx` (+0 -83) _...and 21 more files_ </details> ### 📄 Description File structure has been changes so please give your feedback on it two linting warnings remain, one will be fixed along side with the footter and another needs a bit more knowledge than I have at the current moment but I do not want it to stop the ticket if someone knows a fix you are welcome to fit it just run "npm run lint" and its the non image one --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>