[PR #23] [MERGED] Fix code inspection errors #23

Closed
opened 2026-02-28 15:18:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/TheTedLab/SpotiStats/pull/23
Author: @TheTedLab
Created: 4/17/2024
Status: Merged
Merged: 4/17/2024
Merged by: @TheTedLab

Base: devHead: code-inspection


📝 Commits (1)

  • 56bdad1 Fix code inspection errors

📊 Changes

5 files changed (+74 additions, -72 deletions)

View changed files

📝 src/aggregator/save_artist.py (+12 -0)
📝 src/aggregator/stats_from_files.py (+11 -33)
📝 src/aggregator/stats_update.py (+6 -7)
📝 src/aggregator/stats_utils.py (+40 -16)
📝 tests/test_unit.py (+5 -16)

📄 Description

  1. save_artist.py - Add a response status code handler for non 200
  2. stats_utils.py - Extract change_artist_data albums_ids to utils getter function
  3. stats_update.py - Inplement tracks_data to change_track_data function
  4. stats_from_files.py - Remove unnecessary duplicate parameter artists_path
  5. stats_from_files.py - Extract duplicated code fragment for getting ids from file names to utils function Fix functions and parameters of unit tests according to the changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/TheTedLab/SpotiStats/pull/23 **Author:** [@TheTedLab](https://github.com/TheTedLab) **Created:** 4/17/2024 **Status:** ✅ Merged **Merged:** 4/17/2024 **Merged by:** [@TheTedLab](https://github.com/TheTedLab) **Base:** `dev` ← **Head:** `code-inspection` --- ### 📝 Commits (1) - [`56bdad1`](https://github.com/TheTedLab/SpotiStats/commit/56bdad1405479981add8c3eeda32986010602a8a) Fix code inspection errors ### 📊 Changes **5 files changed** (+74 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `src/aggregator/save_artist.py` (+12 -0) 📝 `src/aggregator/stats_from_files.py` (+11 -33) 📝 `src/aggregator/stats_update.py` (+6 -7) 📝 `src/aggregator/stats_utils.py` (+40 -16) 📝 `tests/test_unit.py` (+5 -16) </details> ### 📄 Description 1. save_artist.py - Add a response status code handler for non 200 2. stats_utils.py - Extract change_artist_data albums_ids to utils getter function 3. stats_update.py - Inplement tracks_data to change_track_data function 4. stats_from_files.py - Remove unnecessary duplicate parameter artists_path 5. stats_from_files.py - Extract duplicated code fragment for getting ids from file names to utils function Fix functions and parameters of unit tests according to the changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 15:18:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SpotiStats#23
No description provided.