[PR #183] [MERGED] Add Musixmatch Lyrics Translation Support #206

New issue

Closed

opened 2026-02-27 19:26:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/183
Author: @kerollosy
Created: 7/25/2025
Status: ✅ Merged
Merged: 10/15/2025
Merged by: @Lambada10

Base: master ← Head: master

📝 Commits (10+)

f22213a Fix: Update Musixmatch API endpoint to use the new version
78b6604 Fix: Add availableLanguages and originalLanguage fields to MusixmatchSearchResponse
46cd78d Fix: Add availableLanguages, originalLanguage, and currentLanguage fields to SongInfo
e42e7e0 feat: Implement LanguageSelector component for language selection in lyrics fetch
f2e7be4 feat: Add LanguageSelector to LyricsSuccessContent for language selection
621fd95 feat: Add getLanguageDisplayName function to return display names for language codes
1438b68 feat: Add language selection functionality to LyricsFetchScreen and SuccessContent
9278118 feat: Implement fetchLyricsInLanguage function in LyricsFetchViewModel and add getLyricsInLanguage method in MusixmatchAPI
f11efc2 Fix: Forgot some commas
e93d2ab feat: Add 'Select Language' string resource for language selection functionality

📊 Changes

10 files changed (+264 additions, -4 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt (+4 -0)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt (+96 -2)
📝 app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt (+3 -0)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Musixmatch.kt (+2 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt (+3 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt (+27 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LanguageSelector.kt (+105 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LyricsSuccessContent.kt (+15 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt (+8 -1)
📝 app/src/main/res/values/strings.xml (+1 -0)

📄 Description

Adds support for displaying lyrics in different languages through Musixmatch API. Users can now select from available translations using a language selector dropdown.

Closes #142

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/183 **Author:** [@kerollosy](https://github.com/kerollosy) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 10/15/2025 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`f22213a`](https://github.com/Lambada10/SongSync/commit/f22213a09729ecf24c84c94a9bf0ad9bd987c229) Fix: Update Musixmatch API endpoint to use the new version - [`78b6604`](https://github.com/Lambada10/SongSync/commit/78b660473c34cc4baee010c7de261a8e3dfc4e73) Fix: Add availableLanguages and originalLanguage fields to MusixmatchSearchResponse - [`46cd78d`](https://github.com/Lambada10/SongSync/commit/46cd78d8ae1ff10598696dc7a0eb584cff6b5298) Fix: Add availableLanguages, originalLanguage, and currentLanguage fields to SongInfo - [`e42e7e0`](https://github.com/Lambada10/SongSync/commit/e42e7e057068ea073b6bd1f51cd39dd6c4da06cf) feat: Implement LanguageSelector component for language selection in lyrics fetch - [`f2e7be4`](https://github.com/Lambada10/SongSync/commit/f2e7be48c1d6cd09deb03427a63758ba48e86093) feat: Add LanguageSelector to LyricsSuccessContent for language selection - [`621fd95`](https://github.com/Lambada10/SongSync/commit/621fd953e350fab0fb97e5c256b2e1a5f2160e1d) feat: Add getLanguageDisplayName function to return display names for language codes - [`1438b68`](https://github.com/Lambada10/SongSync/commit/1438b687a8aa7cdcf51c5d765d37a572cb9fa94b) feat: Add language selection functionality to LyricsFetchScreen and SuccessContent - [`9278118`](https://github.com/Lambada10/SongSync/commit/9278118ba8bdded64a2d68ddaa418ad6bc155bfb) feat: Implement fetchLyricsInLanguage function in LyricsFetchViewModel and add getLyricsInLanguage method in MusixmatchAPI - [`f11efc2`](https://github.com/Lambada10/SongSync/commit/f11efc260fb38d9c5eb974af560121e86fc6d373) Fix: Forgot some commas - [`e93d2ab`](https://github.com/Lambada10/SongSync/commit/e93d2ab47afc00e830321afe7bb286b181d59daa) feat: Add 'Select Language' string resource for language selection functionality ### 📊 Changes **10 files changed** (+264 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt` (+4 -0) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt` (+96 -2) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt` (+3 -0) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Musixmatch.kt` (+2 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt` (+3 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt` (+27 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LanguageSelector.kt` (+105 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LyricsSuccessContent.kt` (+15 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt` (+8 -1) 📝 `app/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description Adds support for displaying lyrics in different languages through Musixmatch API. Users can now select from available translations using a language selector dropdown. Closes #142 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>