starred/SongSync
1
0
Fork 0
mirror of https://github.com/Lambada10/SongSync.git synced 2026-04-25 22:55:54 +03:00
Code Issues 58 Projects Releases 10 Packages Wiki Activity

[PR #84] [MERGED] Refactor #183

New issue
Closed
opened 2026-02-27 19:26:40 +03:00 by kerem · 0 comments
kerem commented 2026-02-27 19:26:40 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/84
Author: @nxoim
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/20/2024
Merged by: @Lambada10

Base: master ← Head: refactor

📝 Commits (10+)

📊 Changes

57 files changed (+3798 additions, -2964 deletions)

View changed files

📝 .idea/compiler.xml (+1 -1)
📝 .idea/misc.xml (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/MainActivity.kt (+81 -146)
➖ app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt (+0 -400)
➕ app/src/main/java/pl/lambada/songsync/data/remote/UpdateService.kt (+56 -0)
➕ app/src/main/java/pl/lambada/songsync/data/remote/UserSettingsController.kt (+92 -0)
➕ app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt (+104 -0)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/AppleAPI.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/LRCLibAPI.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt (+2 -2)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyAPI.kt (+17 -15)
📝 app/src/main/java/pl/lambada/songsync/ui/Navigator.kt (+45 -30)
📝 app/src/main/java/pl/lambada/songsync/ui/components/SongCard.kt (+8 -7)
📝 app/src/main/java/pl/lambada/songsync/ui/components/TextField.kt (+1 -1)
➖ app/src/main/java/pl/lambada/songsync/ui/screens/AboutScreen.kt (+0 -505)
➖ app/src/main/java/pl/lambada/songsync/ui/screens/HomeScreen.kt (+0 -1309)
➖ app/src/main/java/pl/lambada/songsync/ui/screens/SearchScreen.kt (+0 -545)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutScreen.kt (+132 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutViewModel.kt (+55 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/about/components/AboutScreenTopBar.kt (+43 -0)

...and 37 more files

📄 Description

  • Refactored a little hehe
  • Improved fab -> lyrics fetcher transition
  • improved some lyrics fetcher ui

Closes #79

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/84 **Author:** [@nxoim](https://github.com/nxoim) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/20/2024 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `refactor` --- ### 📝 Commits (10+) - [`ecaf9a4`](https://github.com/Lambada10/SongSync/commit/ecaf9a4411e4171ca995b80394e28b94e982185d) moved songs thing into the view model - [`6556119`](https://github.com/Lambada10/SongSync/commit/6556119ade873bf8986ef81d477a723f0db51d1d) moved things around a bit - [`d63a132`](https://github.com/Lambada10/SongSync/commit/d63a13206beaad8df09731ffbd54b590fcf52e23) moved things around a bit - [`b0e0985`](https://github.com/Lambada10/SongSync/commit/b0e098564a01175f8149a6bdbafd00908464f685) moved things around a bit - [`d2c76cd`](https://github.com/Lambada10/SongSync/commit/d2c76cd2c093478766f9f4f6d6a8fed6224232a3) moved things around a bit - [`b9eb29a`](https://github.com/Lambada10/SongSync/commit/b9eb29a521b89e04a70817e078c5018dd34107fb) moved things around a bit - [`6d821a6`](https://github.com/Lambada10/SongSync/commit/6d821a6c31cce3528a500e9c080d2f5f67aa5287) moved things around a bit - [`379c825`](https://github.com/Lambada10/SongSync/commit/379c8258e9c831782a8873638fe7d7017ca29142) moved things around a bit - [`cf8fe10`](https://github.com/Lambada10/SongSync/commit/cf8fe10a5a02b9feed700e06f21053c0dcb26806) moved things around a bit - [`eaf701b`](https://github.com/Lambada10/SongSync/commit/eaf701b0f100dde5b87c2db2e659becc7b98815c) note ### 📊 Changes **57 files changed** (+3798 additions, -2964 deletions) <details> <summary>View changed files</summary> 📝 `.idea/compiler.xml` (+1 -1) 📝 `.idea/misc.xml` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/MainActivity.kt` (+81 -146) ➖ `app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt` (+0 -400) ➕ `app/src/main/java/pl/lambada/songsync/data/remote/UpdateService.kt` (+56 -0) ➕ `app/src/main/java/pl/lambada/songsync/data/remote/UserSettingsController.kt` (+92 -0) ➕ `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt` (+104 -0) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/AppleAPI.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/LRCLibAPI.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt` (+2 -2) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyAPI.kt` (+17 -15) 📝 `app/src/main/java/pl/lambada/songsync/ui/Navigator.kt` (+45 -30) 📝 `app/src/main/java/pl/lambada/songsync/ui/components/SongCard.kt` (+8 -7) 📝 `app/src/main/java/pl/lambada/songsync/ui/components/TextField.kt` (+1 -1) ➖ `app/src/main/java/pl/lambada/songsync/ui/screens/AboutScreen.kt` (+0 -505) ➖ `app/src/main/java/pl/lambada/songsync/ui/screens/HomeScreen.kt` (+0 -1309) ➖ `app/src/main/java/pl/lambada/songsync/ui/screens/SearchScreen.kt` (+0 -545) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutScreen.kt` (+132 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutViewModel.kt` (+55 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/about/components/AboutScreenTopBar.kt` (+43 -0) _...and 37 more files_ </details> ### 📄 Description - Refactored a little hehe - Improved fab -> lyrics fetcher transition - improved some lyrics fetcher ui Closes #79 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 19:26:40 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feat/now-playing
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.2
v4.2.1
v4.2.0
v4.1.0
v4.0.0
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.2.0
v2.1.0
v2.0.0
v1.3
v1.2
v1.1
v1.0
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SongSync#183
No description provided.